From cce21854b96652f00dfbd2102715776deaf51190 Mon Sep 17 00:00:00 2001 From: Ralph Slooten Date: Thu, 24 Jul 2025 17:27:11 +1200 Subject: [PATCH] Chore: Refactor JS functions and remove unused parameters --- server/ui-src/App.vue | 2 +- server/ui-src/components/AppNotifications.vue | 4 ++-- server/ui-src/components/NavMailbox.vue | 4 ++-- server/ui-src/components/NavSelected.vue | 6 +++--- server/ui-src/components/message/HTMLCheck.vue | 5 ++++- server/ui-src/components/message/LinkCheck.vue | 2 +- server/ui-src/components/message/MessageItem.vue | 12 +++++++----- server/ui-src/components/message/MessageRelease.vue | 2 +- server/ui-src/mixins/MessagesMixins.js | 6 +++--- server/ui-src/stores/mailbox.js | 2 +- server/ui-src/views/MailboxView.vue | 2 +- server/ui-src/views/MessageView.vue | 2 +- server/ui-src/views/SearchView.vue | 2 +- 13 files changed, 28 insertions(+), 23 deletions(-) diff --git a/server/ui-src/App.vue b/server/ui-src/App.vue index 852a2e5..77f26ad 100644 --- a/server/ui-src/App.vue +++ b/server/ui-src/App.vue @@ -17,7 +17,7 @@ export default { mixins: [CommonMixins], watch: { - $route(to, from) { + $route() { // hide mobile menu on URL change this.hideNav(); }, diff --git a/server/ui-src/components/AppNotifications.vue b/server/ui-src/components/AppNotifications.vue index 9b2f966..dd61339 100644 --- a/server/ui-src/components/AppNotifications.vue +++ b/server/ui-src/components/AppNotifications.vue @@ -52,7 +52,7 @@ export default { let response; try { response = JSON.parse(e.data); - } catch (e) { + } catch { return; } @@ -128,7 +128,7 @@ export default { } }; - ws.onclose = (e) => { + ws.onclose = () => { if (this.socketLastConnection === 0) { // connection failed immediately after connecting to Mailpit implies proxy websockets aren't configured console.log("Unable to connect to websocket, disabling websocket support"); diff --git a/server/ui-src/components/NavMailbox.vue b/server/ui-src/components/NavMailbox.vue index 1c77e08..73816fe 100644 --- a/server/ui-src/components/NavMailbox.vue +++ b/server/ui-src/components/NavMailbox.vue @@ -47,14 +47,14 @@ export default { }, markAllRead() { - this.put(this.resolve(`/api/v1/messages`), { read: true }, (response) => { + this.put(this.resolve(`/api/v1/messages`), { read: true }, () => { window.scrollInPlace = true; this.loadMessages(); }); }, deleteAllMessages() { - this.delete(this.resolve(`/api/v1/messages`), false, (response) => { + this.delete(this.resolve(`/api/v1/messages`), false, () => { pagination.start = 0; this.loadMessages(); }); diff --git a/server/ui-src/components/NavSelected.vue b/server/ui-src/components/NavSelected.vue index 1e0ad91..8613837 100644 --- a/server/ui-src/components/NavSelected.vue +++ b/server/ui-src/components/NavSelected.vue @@ -28,7 +28,7 @@ export default { if (!mailbox.selected.length) { return false; } - this.put(this.resolve(`/api/v1/messages`), { Read: true, IDs: mailbox.selected }, (response) => { + this.put(this.resolve(`/api/v1/messages`), { Read: true, IDs: mailbox.selected }, () => { window.scrollInPlace = true; this.loadMessages(); }); @@ -43,7 +43,7 @@ export default { if (!mailbox.selected.length) { return false; } - this.put(this.resolve(`/api/v1/messages`), { Read: false, IDs: mailbox.selected }, (response) => { + this.put(this.resolve(`/api/v1/messages`), { Read: false, IDs: mailbox.selected }, () => { window.scrollInPlace = true; this.loadMessages(); }); @@ -57,7 +57,7 @@ export default { return false; } - this.delete(this.resolve(`/api/v1/messages`), { IDs: ids }, (response) => { + this.delete(this.resolve(`/api/v1/messages`), { IDs: ids }, () => { window.scrollInPlace = true; this.loadMessages(); }); diff --git a/server/ui-src/components/message/HTMLCheck.vue b/server/ui-src/components/message/HTMLCheck.vue index 454859c..5f5cfdd 100644 --- a/server/ui-src/components/message/HTMLCheck.vue +++ b/server/ui-src/components/message/HTMLCheck.vue @@ -257,7 +257,10 @@ export default { if (platforms) { try { this.platforms = JSON.parse(platforms); - } catch (e) {} + } catch { + // if parsing fails, reset to default + this.platforms = []; + } } // set all options diff --git a/server/ui-src/components/message/LinkCheck.vue b/server/ui-src/components/message/LinkCheck.vue index f2616cb..0fc9799 100644 --- a/server/ui-src/components/message/LinkCheck.vue +++ b/server/ui-src/components/message/LinkCheck.vue @@ -153,7 +153,7 @@ export default { this.error = error.message; } }) - .then((result) => { + .then(() => { // always run this.loading = false; }); diff --git a/server/ui-src/components/message/MessageItem.vue b/server/ui-src/components/message/MessageItem.vue index 1369f26..d6695ec 100644 --- a/server/ui-src/components/message/MessageItem.vue +++ b/server/ui-src/components/message/MessageItem.vue @@ -143,12 +143,12 @@ export default { window.addEventListener("resize", this.resizeIFrames); const headersTab = document.getElementById("nav-headers-tab"); - headersTab.addEventListener("shown.bs.tab", (event) => { + headersTab.addEventListener("shown.bs.tab", () => { this.loadHeaders = true; }); const rawTab = document.getElementById("nav-raw-tab"); - rawTab.addEventListener("shown.bs.tab", (event) => { + rawTab.addEventListener("shown.bs.tab", () => { this.srcURI = this.resolve("/api/v1/message/" + this.message.ID + "/raw"); this.resizeIFrames(); }); @@ -180,7 +180,7 @@ export default { this.isHTMLTabSelected(); document.querySelectorAll('button[data-bs-toggle="tab"]').forEach((listObj) => { - listObj.addEventListener("shown.bs.tab", (event) => { + listObj.addEventListener("shown.bs.tab", () => { this.isHTMLTabSelected(); }); }); @@ -203,7 +203,9 @@ export default { anchorEl.setAttribute("target", "_blank"); } } - } catch (error) {} + } catch { + // ignore errors when accessing the iframe content + } this.resizeIFrames(); } }, 500); @@ -280,7 +282,7 @@ export default { Tags: this.messageTags, }; - this.put(this.resolve("/api/v1/tags"), data, (response) => { + this.put(this.resolve("/api/v1/tags"), data, () => { window.scrollInPlace = true; this.$emit("loadMessages"); }); diff --git a/server/ui-src/components/message/MessageRelease.vue b/server/ui-src/components/message/MessageRelease.vue index 92227cd..de63585 100644 --- a/server/ui-src/components/message/MessageRelease.vue +++ b/server/ui-src/components/message/MessageRelease.vue @@ -64,7 +64,7 @@ export default { To: this.addresses, }; - this.post(this.resolve("/api/v1/message/" + this.message.ID + "/release"), data, (response) => { + this.post(this.resolve("/api/v1/message/" + this.message.ID + "/release"), data, () => { this.modal("ReleaseModal").hide(); if (this.deleteAfterRelease) { this.$emit("delete"); diff --git a/server/ui-src/mixins/MessagesMixins.js b/server/ui-src/mixins/MessagesMixins.js index 54eeb62..1d67f11 100644 --- a/server/ui-src/mixins/MessagesMixins.js +++ b/server/ui-src/mixins/MessagesMixins.js @@ -14,7 +14,7 @@ export default { }, watch: { - "mailbox.refresh": function (v) { + "mailbox.refresh"(v) { if (v) { // trigger a refresh this.loadMessages(); @@ -45,9 +45,9 @@ export default { const params = {}; mailbox.selected = []; - params["limit"] = pagination.limit; + params.limit = pagination.limit; if (pagination.start > 0) { - params["start"] = pagination.start; + params.start = pagination.start; } this.get(this.apiURI, params, (response) => { diff --git a/server/ui-src/stores/mailbox.js b/server/ui-src/stores/mailbox.js index 917b5c8..a6973ed 100644 --- a/server/ui-src/stores/mailbox.js +++ b/server/ui-src/stores/mailbox.js @@ -33,7 +33,7 @@ export const mailbox = reactive({ watch( () => mailbox.count, - (v) => { + () => { mailbox.selected = []; }, ); diff --git a/server/ui-src/views/MailboxView.vue b/server/ui-src/views/MailboxView.vue index ade60b5..90fad61 100644 --- a/server/ui-src/views/MailboxView.vue +++ b/server/ui-src/views/MailboxView.vue @@ -36,7 +36,7 @@ export default { }, watch: { - $route(to, from) { + $route() { this.loadMailbox(); }, }, diff --git a/server/ui-src/views/MessageView.vue b/server/ui-src/views/MessageView.vue index ae8bd40..07b7da4 100644 --- a/server/ui-src/views/MessageView.vue +++ b/server/ui-src/views/MessageView.vue @@ -94,7 +94,7 @@ export default { }, watch: { - $route(to, from) { + $route() { this.loadMessage(); }, }, diff --git a/server/ui-src/views/SearchView.vue b/server/ui-src/views/SearchView.vue index a7b01a2..16a3d32 100644 --- a/server/ui-src/views/SearchView.vue +++ b/server/ui-src/views/SearchView.vue @@ -36,7 +36,7 @@ export default { }, watch: { - $route(to, from) { + $route() { this.doSearch(); }, },