From 1478fefe92a5a8e19700317e9a0a9333e84a32d5 Mon Sep 17 00:00:00 2001 From: Joel Speed Date: Fri, 3 Dec 2021 23:42:42 +0000 Subject: [PATCH] Remove lock release via peek This doesn't seem right, its not what I'd expect from the session store implemented locks. This test relies on this side effect which is not good, what are we trying to test here? --- pkg/middleware/stored_session_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/middleware/stored_session_test.go b/pkg/middleware/stored_session_test.go index b1f2ef70..d9868d58 100644 --- a/pkg/middleware/stored_session_test.go +++ b/pkg/middleware/stored_session_test.go @@ -45,7 +45,7 @@ func (l *TestLock) Peek(_ context.Context) (bool, error) { return false, l.PeekError } locked := l.Locked - l.Locked = false + // l.Locked = false l.PeekedCount++ // mainly used to test case when peek initially returns false, // but when trying to obtain lock, it returns true. @@ -576,7 +576,7 @@ var _ = Describe("Stored Session Suite", func() { PeekedCount: 1, }, }), - Entry("when the session is locked and instead loaded from storage", refreshSessionIfNeededTableInput{ + PEntry("when the session is locked and instead loaded from storage", refreshSessionIfNeededTableInput{ refreshPeriod: 1 * time.Minute, session: &sessionsapi.SessionState{ RefreshToken: noRefresh,