From 8bec67beb71eb75cbd73442ced8282c9bd124af9 Mon Sep 17 00:00:00 2001 From: Evgeni Gordeev Date: Fri, 19 Jun 2020 22:27:36 -0500 Subject: [PATCH] code review comments --- contrib/local-environment/Makefile | 6 +++--- contrib/local-environment/kubernetes/Makefile | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/contrib/local-environment/Makefile b/contrib/local-environment/Makefile index 5b43aba4..512e6fab 100644 --- a/contrib/local-environment/Makefile +++ b/contrib/local-environment/Makefile @@ -24,9 +24,9 @@ keycloak-%: .PHONY: kubernetes-up kubernetes-up: - cd kubernetes && make create-cluster - cd kubernetes && make deploy + make -C kubernetes create-cluster + make -C kubernetes deploy .PHONY: kubernetes-down kubernetes-down: - cd kubernetes && make delete-cluster + make -C kubernetes delete-cluster diff --git a/contrib/local-environment/kubernetes/Makefile b/contrib/local-environment/kubernetes/Makefile index 917207ac..55fe927b 100644 --- a/contrib/local-environment/kubernetes/Makefile +++ b/contrib/local-environment/kubernetes/Makefile @@ -63,4 +63,5 @@ helm-undeploy: # creates K8S manifest from helm chart .PHONY: helm-create-manifest helm-create-manifest: helm-init - helm template --namespace default oauth2-proxy-example . > oauth2-proxy-example-full.yaml + echo "# WARNING: This file is auto-generated by `make helm-create-manifest`! DO NOT EDIT MANUALLY!" > oauth2-proxy-example-full.yaml + helm template --namespace default oauth2-proxy-example . >> oauth2-proxy-example-full.yaml