base64 cookie support

cookie/cookies.go

@@ -85,8 +85,8 @@ type Cipher struct {
 }
 
 // NewCipher returns a new aes Cipher for encrypting cookie values
-func NewCipher(secret string) (*Cipher, error) {
-	c, err := aes.NewCipher([]byte(secret))
+func NewCipher(secret []byte) (*Cipher, error) {
+	c, err := aes.NewCipher(secret)
 	if err != nil {
 		return nil, err
 	}

cookie/cookies_test.go

@@ -1,6 +1,7 @@
 package cookie
 
 import (
+	"encoding/base64"
 	"testing"
 
 	"github.com/bmizerany/assert"
@@ -9,7 +10,25 @@ import (
 func TestEncodeAndDecodeAccessToken(t *testing.T) {
 	const secret = "0123456789abcdefghijklmnopqrstuv"
 	const token = "my access token"
-	c, err := NewCipher(secret)
+	c, err := NewCipher([]byte(secret))
+	assert.Equal(t, nil, err)
+
+	encoded, err := c.Encrypt(token)
+	assert.Equal(t, nil, err)
+
+	decoded, err := c.Decrypt(encoded)
+	assert.Equal(t, nil, err)
+
+	assert.NotEqual(t, token, encoded)
+	assert.Equal(t, token, decoded)
+}
+
+func TestEncodeAndDecodeAccessTokenB64(t *testing.T) {
+	const secret_b64 = "A3Xbr6fu6Al0HkgrP1ztjb-mYiwmxgNPP-XbNsz1WBk="
+	const token = "my access token"
+
+	secret, err := base64.URLEncoding.DecodeString(secret_b64)
+	c, err := NewCipher([]byte(secret))
 	assert.Equal(t, nil, err)
 
 	encoded, err := c.Encrypt(token)