chores: major upgrade of golangci-lint from v1.64.8 to v2.1.6 (#3062)

.golangci.yml migrated with "golangci-lint migrated" and then tweaked to add comments back.

.github/workflows/ci.yml

@@ -25,7 +25,7 @@ jobs:
     - name: Get dependencies
       env:
         # renovate: datasource=github-tags depName=golangci/golangci-lint
-        GOLANGCI_LINT_VERSION: v1.64.8
+        GOLANGCI_LINT_VERSION: v2.1.6
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
         curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

.github/workflows/publish-release.yml

@@ -50,7 +50,7 @@ jobs:
     - name: Get dependencies
       env:
         # renovate: datasource=github-tags depName=golangci/golangci-lint
-        GOLANGCI_LINT_VERSION: v1.64.8
+        GOLANGCI_LINT_VERSION: v2.1.6
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
         curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

.golangci.yml

@@ -1,50 +1,65 @@
-run:
+version: "2"
-  timeout: 120s
 linters:
+  default: none
   enable:
+    - bodyclose
+    - copyloopvar
+    - dogsled
+    - goconst
+    - gocritic
+    - goprintffuncname
+    - gosec
     - govet
     - ineffassign
-    - goconst
-    - gofmt
-    - goimports
-    - gosec
-    - gosimple
-    - staticcheck
-    - typecheck
-    - unused
-    - bodyclose
-    - dogsled
-    - goprintffuncname
     - misspell
     - prealloc
-    - copyloopvar
-    - stylecheck
-    - unconvert
-    - gocritic
     - revive
-  disable-all: true
+    - staticcheck
-issues:
+    - unconvert
-  exclude:
+    - unused
-    # To ease migration to golangci-lint v2.1
+  exclusions:
-    # https://staticcheck.dev/docs/checks/#QF1008
+    generated: lax
-    - QF1008
+    presets:
-  exclude-rules:
+      - comments
-    - path: _test\.go
+      - common-false-positives
-      linters:
+      - legacy
-        - scopelint
+      - std-error-handling
-        - bodyclose
+    rules:
-        - unconvert
+      - linters:
-        - gocritic
+          - bodyclose
-        - gosec
+          - goconst
-        - goconst
+          - gocritic
-        - revive
+          - gosec
-    - path: _test\.go
+          - revive
-      linters:
+          - scopelint
-        - revive
+          - unconvert
-      text: "dot-imports:"
+        path: _test\.go
-    # If we have tests in shared test folders, these can be less strictly linted
+      - linters:
-    - path: tests/.*_tests\.go
+          - revive
-      linters:
+        path: _test\.go
-        - revive
+        text: 'dot-imports:'
-        - bodyclose
+      # # If we have tests in shared test folders, these can be less strictly linted
-        - stylecheck
+      - linters:
+          - bodyclose
+          - revive
+          - staticcheck
+        path: tests/.*_tests\.go
+      # See https://github.com/oauth2-proxy/oauth2-proxy/issues/3060
+      # https://staticcheck.dev/docs/checks/#QF1008
+      - linters:
+          - staticcheck
+        text: QF1008
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$