mirror of
https://github.com/oauth2-proxy/oauth2-proxy.git
synced 2024-11-28 09:08:44 +02:00
1b6c54cae1
* Changed how gitlab-group is parsed, from string to []string See #637 * Point out that gitlab-group can be a list See #637 * Reflect to the []string change on pkg/apis/options/options.go See #637 * Move cfg option gitlab_group to gitlab_groups See #637 * Renamed Group to Groups See #637 * Reflect the change on gitlab.go as well See #637 * Added #639 * Added the author of #639 to the CHANGELOG * Add the gitlab_groups env change to CHANGELOG.md See #639 Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk> Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
168 lines
4.2 KiB
Go
168 lines
4.2 KiB
Go
package providers
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"testing"
|
|
|
|
"github.com/oauth2-proxy/oauth2-proxy/pkg/apis/sessions"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func testGitLabProvider(hostname string) *GitLabProvider {
|
|
p := NewGitLabProvider(
|
|
&ProviderData{
|
|
ProviderName: "",
|
|
LoginURL: &url.URL{},
|
|
RedeemURL: &url.URL{},
|
|
ProfileURL: &url.URL{},
|
|
ValidateURL: &url.URL{},
|
|
Scope: ""})
|
|
if hostname != "" {
|
|
updateURL(p.Data().LoginURL, hostname)
|
|
updateURL(p.Data().RedeemURL, hostname)
|
|
updateURL(p.Data().ProfileURL, hostname)
|
|
updateURL(p.Data().ValidateURL, hostname)
|
|
}
|
|
|
|
return p
|
|
}
|
|
|
|
func testGitLabBackend() *httptest.Server {
|
|
userInfo := `
|
|
{
|
|
"nickname": "FooBar",
|
|
"email": "foo@bar.com",
|
|
"email_verified": false,
|
|
"groups": ["foo", "bar"]
|
|
}
|
|
`
|
|
authHeader := "Bearer gitlab_access_token"
|
|
|
|
return httptest.NewServer(http.HandlerFunc(
|
|
func(w http.ResponseWriter, r *http.Request) {
|
|
if r.URL.Path == "/oauth/userinfo" {
|
|
if r.Header["Authorization"][0] == authHeader {
|
|
w.WriteHeader(200)
|
|
w.Write([]byte(userInfo))
|
|
} else {
|
|
w.WriteHeader(401)
|
|
}
|
|
} else {
|
|
w.WriteHeader(404)
|
|
}
|
|
}))
|
|
}
|
|
|
|
func TestGitLabProviderBadToken(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
|
|
session := &sessions.SessionState{AccessToken: "unexpected_gitlab_access_token"}
|
|
_, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.NotEqual(t, nil, err)
|
|
}
|
|
|
|
func TestGitLabProviderUnverifiedEmailDenied(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
_, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.NotEqual(t, nil, err)
|
|
}
|
|
|
|
func TestGitLabProviderUnverifiedEmailAllowed(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
email, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.Equal(t, nil, err)
|
|
assert.Equal(t, "foo@bar.com", email)
|
|
}
|
|
|
|
func TestGitLabProviderUsername(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
username, err := p.GetUserName(context.Background(), session)
|
|
assert.Equal(t, nil, err)
|
|
assert.Equal(t, "FooBar", username)
|
|
}
|
|
|
|
func TestGitLabProviderGroupMembershipValid(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
p.Groups = []string{"foo"}
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
email, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.Equal(t, nil, err)
|
|
assert.Equal(t, "foo@bar.com", email)
|
|
}
|
|
|
|
func TestGitLabProviderGroupMembershipMissing(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
p.Groups = []string{"baz"}
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
_, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.NotEqual(t, nil, err)
|
|
}
|
|
|
|
func TestGitLabProviderEmailDomainValid(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
p.EmailDomains = []string{"bar.com"}
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
email, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.Equal(t, nil, err)
|
|
assert.Equal(t, "foo@bar.com", email)
|
|
}
|
|
|
|
func TestGitLabProviderEmailDomainInvalid(t *testing.T) {
|
|
b := testGitLabBackend()
|
|
defer b.Close()
|
|
|
|
bURL, _ := url.Parse(b.URL)
|
|
p := testGitLabProvider(bURL.Host)
|
|
p.AllowUnverifiedEmail = true
|
|
p.EmailDomains = []string{"baz.com"}
|
|
|
|
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}
|
|
_, err := p.GetEmailAddress(context.Background(), session)
|
|
assert.NotEqual(t, nil, err)
|
|
}
|