mirror of
https://github.com/oauth2-proxy/oauth2-proxy.git
synced 2024-12-12 11:15:02 +02:00
65016c8da1
* Allow complex structure for groups in group claim. * Remove unused constant * Update variable name * Fix linting * Use helper method * Log error if not possible to append group value * Add missing import * Use own logger * Fix imports * Remove Dockerfile for testing * Add Changelog entry * Use formatGroup helper method and update tests * Return string instead of string array * Remove groups variable * Return error in format method. * Reorder imports Co-authored-by: Nick Meves <nick.meves@greenhouse.io>
324 lines
9.1 KiB
Go
324 lines
9.1 KiB
Go
package providers
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"reflect"
|
|
"strings"
|
|
"time"
|
|
|
|
oidc "github.com/coreos/go-oidc"
|
|
"golang.org/x/oauth2"
|
|
|
|
"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/apis/sessions"
|
|
"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/logger"
|
|
"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/requests"
|
|
)
|
|
|
|
const emailClaim = "email"
|
|
|
|
// OIDCProvider represents an OIDC based Identity Provider
|
|
type OIDCProvider struct {
|
|
*ProviderData
|
|
|
|
Verifier *oidc.IDTokenVerifier
|
|
AllowUnverifiedEmail bool
|
|
UserIDClaim string
|
|
GroupsClaim string
|
|
}
|
|
|
|
// NewOIDCProvider initiates a new OIDCProvider
|
|
func NewOIDCProvider(p *ProviderData) *OIDCProvider {
|
|
p.ProviderName = "OpenID Connect"
|
|
return &OIDCProvider{ProviderData: p}
|
|
}
|
|
|
|
var _ Provider = (*OIDCProvider)(nil)
|
|
|
|
// Redeem exchanges the OAuth2 authentication token for an ID token
|
|
func (p *OIDCProvider) Redeem(ctx context.Context, redirectURL, code string) (s *sessions.SessionState, err error) {
|
|
clientSecret, err := p.GetClientSecret()
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
c := oauth2.Config{
|
|
ClientID: p.ClientID,
|
|
ClientSecret: clientSecret,
|
|
Endpoint: oauth2.Endpoint{
|
|
TokenURL: p.RedeemURL.String(),
|
|
},
|
|
RedirectURL: redirectURL,
|
|
}
|
|
token, err := c.Exchange(ctx, code)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("token exchange: %v", err)
|
|
}
|
|
|
|
// in the initial exchange the id token is mandatory
|
|
idToken, err := p.findVerifiedIDToken(ctx, token)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("could not verify id_token: %v", err)
|
|
} else if idToken == nil {
|
|
return nil, fmt.Errorf("token response did not contain an id_token")
|
|
}
|
|
|
|
s, err = p.createSessionState(ctx, token, idToken)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("unable to update session: %v", err)
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
// RefreshSessionIfNeeded checks if the session has expired and uses the
|
|
// RefreshToken to fetch a new Access Token (and optional ID token) if required
|
|
func (p *OIDCProvider) RefreshSessionIfNeeded(ctx context.Context, s *sessions.SessionState) (bool, error) {
|
|
if s == nil || (s.ExpiresOn != nil && s.ExpiresOn.After(time.Now())) || s.RefreshToken == "" {
|
|
return false, nil
|
|
}
|
|
|
|
err := p.redeemRefreshToken(ctx, s)
|
|
if err != nil {
|
|
return false, fmt.Errorf("unable to redeem refresh token: %v", err)
|
|
}
|
|
|
|
fmt.Printf("refreshed access token %s (expired on %s)\n", s, s.ExpiresOn)
|
|
return true, nil
|
|
}
|
|
|
|
func (p *OIDCProvider) redeemRefreshToken(ctx context.Context, s *sessions.SessionState) (err error) {
|
|
clientSecret, err := p.GetClientSecret()
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
c := oauth2.Config{
|
|
ClientID: p.ClientID,
|
|
ClientSecret: clientSecret,
|
|
Endpoint: oauth2.Endpoint{
|
|
TokenURL: p.RedeemURL.String(),
|
|
},
|
|
}
|
|
t := &oauth2.Token{
|
|
RefreshToken: s.RefreshToken,
|
|
Expiry: time.Now().Add(-time.Hour),
|
|
}
|
|
token, err := c.TokenSource(ctx, t).Token()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get token: %v", err)
|
|
}
|
|
|
|
// in the token refresh response the id_token is optional
|
|
idToken, err := p.findVerifiedIDToken(ctx, token)
|
|
if err != nil {
|
|
return fmt.Errorf("unable to extract id_token from response: %v", err)
|
|
}
|
|
|
|
newSession, err := p.createSessionState(ctx, token, idToken)
|
|
if err != nil {
|
|
return fmt.Errorf("unable create new session state from response: %v", err)
|
|
}
|
|
|
|
// It's possible that if the refresh token isn't in the token response the session will not contain an id token
|
|
// if it doesn't it's probably better to retain the old one
|
|
if newSession.IDToken != "" {
|
|
s.IDToken = newSession.IDToken
|
|
s.Email = newSession.Email
|
|
s.User = newSession.User
|
|
s.Groups = newSession.Groups
|
|
s.PreferredUsername = newSession.PreferredUsername
|
|
}
|
|
|
|
s.AccessToken = newSession.AccessToken
|
|
s.RefreshToken = newSession.RefreshToken
|
|
s.CreatedAt = newSession.CreatedAt
|
|
s.ExpiresOn = newSession.ExpiresOn
|
|
|
|
return
|
|
}
|
|
|
|
func (p *OIDCProvider) findVerifiedIDToken(ctx context.Context, token *oauth2.Token) (*oidc.IDToken, error) {
|
|
|
|
getIDToken := func() (string, bool) {
|
|
rawIDToken, _ := token.Extra("id_token").(string)
|
|
return rawIDToken, len(strings.TrimSpace(rawIDToken)) > 0
|
|
}
|
|
|
|
if rawIDToken, present := getIDToken(); present {
|
|
verifiedIDToken, err := p.Verifier.Verify(ctx, rawIDToken)
|
|
return verifiedIDToken, err
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (p *OIDCProvider) createSessionState(ctx context.Context, token *oauth2.Token, idToken *oidc.IDToken) (*sessions.SessionState, error) {
|
|
|
|
var newSession *sessions.SessionState
|
|
|
|
if idToken == nil {
|
|
newSession = &sessions.SessionState{}
|
|
} else {
|
|
var err error
|
|
newSession, err = p.createSessionStateInternal(ctx, idToken, token)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
created := time.Now()
|
|
newSession.AccessToken = token.AccessToken
|
|
newSession.RefreshToken = token.RefreshToken
|
|
newSession.CreatedAt = &created
|
|
newSession.ExpiresOn = &token.Expiry
|
|
return newSession, nil
|
|
}
|
|
|
|
func (p *OIDCProvider) CreateSessionStateFromBearerToken(ctx context.Context, rawIDToken string, idToken *oidc.IDToken) (*sessions.SessionState, error) {
|
|
newSession, err := p.createSessionStateInternal(ctx, idToken, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
newSession.AccessToken = rawIDToken
|
|
newSession.IDToken = rawIDToken
|
|
newSession.RefreshToken = ""
|
|
newSession.ExpiresOn = &idToken.Expiry
|
|
|
|
return newSession, nil
|
|
}
|
|
|
|
func (p *OIDCProvider) createSessionStateInternal(ctx context.Context, idToken *oidc.IDToken, token *oauth2.Token) (*sessions.SessionState, error) {
|
|
|
|
newSession := &sessions.SessionState{}
|
|
|
|
if idToken == nil {
|
|
return newSession, nil
|
|
}
|
|
|
|
claims, err := p.findClaimsFromIDToken(ctx, idToken, token)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("couldn't extract claims from id_token (%v)", err)
|
|
}
|
|
|
|
if token != nil {
|
|
newSession.IDToken = token.Extra("id_token").(string)
|
|
}
|
|
|
|
newSession.Email = claims.UserID // TODO Rename SessionState.Email to .UserID in the near future
|
|
|
|
newSession.User = claims.Subject
|
|
newSession.Groups = claims.Groups
|
|
newSession.PreferredUsername = claims.PreferredUsername
|
|
|
|
verifyEmail := (p.UserIDClaim == emailClaim) && !p.AllowUnverifiedEmail
|
|
if verifyEmail && claims.Verified != nil && !*claims.Verified {
|
|
return nil, fmt.Errorf("email in id_token (%s) isn't verified", claims.UserID)
|
|
}
|
|
|
|
return newSession, nil
|
|
}
|
|
|
|
// ValidateSessionState checks that the session's IDToken is still valid
|
|
func (p *OIDCProvider) ValidateSessionState(ctx context.Context, s *sessions.SessionState) bool {
|
|
_, err := p.Verifier.Verify(ctx, s.IDToken)
|
|
return err == nil
|
|
}
|
|
|
|
func (p *OIDCProvider) findClaimsFromIDToken(ctx context.Context, idToken *oidc.IDToken, token *oauth2.Token) (*OIDCClaims, error) {
|
|
claims := &OIDCClaims{}
|
|
|
|
// Extract default claims.
|
|
if err := idToken.Claims(&claims); err != nil {
|
|
return nil, fmt.Errorf("failed to parse default id_token claims: %v", err)
|
|
}
|
|
// Extract custom claims.
|
|
if err := idToken.Claims(&claims.rawClaims); err != nil {
|
|
return nil, fmt.Errorf("failed to parse all id_token claims: %v", err)
|
|
}
|
|
|
|
userID := claims.rawClaims[p.UserIDClaim]
|
|
if userID != nil {
|
|
claims.UserID = fmt.Sprint(userID)
|
|
}
|
|
|
|
claims.Groups = p.extractGroupsFromRawClaims(claims.rawClaims)
|
|
|
|
// userID claim was not present or was empty in the ID Token
|
|
if claims.UserID == "" {
|
|
// BearerToken case, allow empty UserID
|
|
// ProfileURL checks below won't work since we don't have an access token
|
|
if token == nil {
|
|
claims.UserID = claims.Subject
|
|
return claims, nil
|
|
}
|
|
|
|
profileURL := p.ProfileURL.String()
|
|
if profileURL == "" || token.AccessToken == "" {
|
|
return nil, fmt.Errorf("id_token did not contain user ID claim (%q)", p.UserIDClaim)
|
|
}
|
|
|
|
// If the userinfo endpoint profileURL is defined, then there is a chance the userinfo
|
|
// contents at the profileURL contains the email.
|
|
// Make a query to the userinfo endpoint, and attempt to locate the email from there.
|
|
respJSON, err := requests.New(profileURL).
|
|
WithContext(ctx).
|
|
WithHeaders(makeOIDCHeader(token.AccessToken)).
|
|
Do().
|
|
UnmarshalJSON()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
userID, err := respJSON.Get(p.UserIDClaim).String()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("neither id_token nor userinfo endpoint contained user ID claim (%q)", p.UserIDClaim)
|
|
}
|
|
|
|
claims.UserID = userID
|
|
}
|
|
|
|
return claims, nil
|
|
}
|
|
|
|
func (p *OIDCProvider) extractGroupsFromRawClaims(rawClaims map[string]interface{}) []string {
|
|
groups := []string{}
|
|
|
|
rawGroups, ok := rawClaims[p.GroupsClaim].([]interface{})
|
|
if rawGroups != nil && ok {
|
|
for _, rawGroup := range rawGroups {
|
|
formattedGroup, err := formatGroup(rawGroup)
|
|
if err != nil {
|
|
logger.Errorf("unable to format group of type %s with error %s", reflect.TypeOf(rawGroup), err)
|
|
continue
|
|
}
|
|
groups = append(groups, formattedGroup)
|
|
}
|
|
}
|
|
|
|
return groups
|
|
|
|
}
|
|
|
|
func formatGroup(rawGroup interface{}) (string, error) {
|
|
group, ok := rawGroup.(string)
|
|
if !ok {
|
|
jsonGroup, err := json.Marshal(rawGroup)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
group = string(jsonGroup)
|
|
}
|
|
return group, nil
|
|
}
|
|
|
|
type OIDCClaims struct {
|
|
rawClaims map[string]interface{}
|
|
UserID string
|
|
Subject string `json:"sub"`
|
|
Verified *bool `json:"email_verified"`
|
|
PreferredUsername string `json:"preferred_username"`
|
|
Groups []string `json:"-"`
|
|
}
|