go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-25 22:41:46 +02:00
Code Issues Releases Activity

Add parent context to SpanProcessor.OnStart (#1333)

Browse Source 
* Add parent context to SpanProcessor.OnStart

The spec requires doing so. Right now SpanProcessor implementations
aren't doing anything with this argument.

* Update changelog

* Fix typo in test name
This commit is contained in:
Johannes Liebermann
2020-11-16 17:45:49 +01:00
committed by GitHub
parent 63a11144cf
commit 070b657c21
9 changed files with 75 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/trace/batch_span_processor_test.go
View File

@@ -63,7 +63,7 @@ var _ export.SpanExporter = (*testBatchExporter)(nil)
func TestNewBatchSpanProcessorWithNilExporter(t *testing.T) {
bsp := sdktrace.NewBatchSpanProcessor(nil)
// These should not panic.
bsp.OnStart(&export.SpanData{})
bsp.OnStart(context.Background(), &export.SpanData{})
bsp.OnEnd(&export.SpanData{})
bsp.ForceFlush()
err := bsp.Shutdown(context.Background())