From 0a87dc8c4019f621007af4dd3b72d2fe50d02acf Mon Sep 17 00:00:00 2001 From: Joe Schafer Date: Thu, 24 Apr 2025 00:33:59 -0700 Subject: [PATCH] Fix tracestate benchmarks (#6690) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The benchmark failed because the list-member keys were invalid. Co-authored-by: Robert Pająk --- trace/tracestate_test.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/trace/tracestate_test.go b/trace/tracestate_test.go index bc9258384..aff07d46c 100644 --- a/trace/tracestate_test.go +++ b/trace/tracestate_test.go @@ -595,19 +595,19 @@ func BenchmarkParseTraceState(b *testing.B) { }{ { name: "single key", - in: "somewhatRealisticKeyLength=someValueAbcdefgh1234567890", + in: "somewhat-realistic-key-length=someValueAbcdefgh1234567890", }, { name: "tenant single key", - in: "somewhatRealisticKeyLength@someTenant=someValueAbcdefgh1234567890", + in: "somewhat-realistic-key-length@some-tenant=someValueAbcdefgh1234567890", }, { name: "three keys", - in: "someKeyName.One=someValue1,someKeyName.Two=someValue2,someKeyName.Three=someValue3", + in: "some-key-name/one=someValue1,some-key-name/two=someValue2,some-key-name/three=someValue3", }, { name: "tenant three keys", - in: "someKeyName.One@tenant=someValue1,someKeyName.Two@tenant=someValue2,someKeyName.Three@tenant=someValue3", + in: "some-key-name/one@tenant=someValue1,some-key-name/two@tenant=someValue2,some-key-name/three@tenant=someValue3", }, } for _, bench := range benches { @@ -616,7 +616,10 @@ func BenchmarkParseTraceState(b *testing.B) { b.ResetTimer() for i := 0; i < b.N; i++ { - _, _ = ParseTraceState(bench.in) + _, err := ParseTraceState(bench.in) + if err != nil { + b.Fatalf("parse TraceState: %v", err) + } } }) }