go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-13 01:00:22 +02:00
Code Issues Releases Activity

Support cumulative, delta, and pass-through exporters (#840)

Browse Source 
* Update Process()

* Checkpoint

* Add subtractor; fix test

* Fix all simple integrator tests

* Build the rest (checkpoint)

* Pass all but Prometheus tests

* Precommit pass

* Add aggregation.Kind argument to ExportKindFor

* Remove Subtractor support

* Remove dead test code

* Restore the Subtractor code

* Fix the tests

* Comments

* Add tests for MetricKind

* Add ChangeSign test

* Test ExportKind

* New file

* Rename ChangeSign

* Remove a TODO, add a TODO

* Remove Stateful remnants

* Typo

* Typo

* Test an invalid export kind

* Comments

* Lint

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This commit is contained in:
Joshua MacDonald
2020-06-22 22:59:51 -07:00
committed by GitHub
parent e5267a3aa8
commit 0e2fdfc682
26 changed files with 976 additions and 335 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
sdk/metric/controller/pull/pull_test.go
View File

@ -25,6 +25,7 @@ import (
"go.opentelemetry.io/otel/api/kv"
"go.opentelemetry.io/otel/api/label"
"go.opentelemetry.io/otel/api/metric"
export "go.opentelemetry.io/otel/sdk/export/metric"
"go.opentelemetry.io/otel/sdk/metric/controller/pull"
controllerTest "go.opentelemetry.io/otel/sdk/metric/controller/test"
"go.opentelemetry.io/otel/sdk/metric/integrator/test"
@ -34,8 +35,8 @@ import (
func TestPullNoCache(t *testing.T) {
puller := pull.New(
selector.NewWithExactDistribution(),
export.CumulativeExporter,
pull.WithCachePeriod(0),
pull.WithStateful(true),
)
ctx := context.Background()
@ -46,7 +47,7 @@ func TestPullNoCache(t *testing.T) {
require.NoError(t, puller.Collect(ctx))
records := test.NewOutput(label.DefaultEncoder())
require.NoError(t, puller.ForEach(records.AddRecord))
require.NoError(t, puller.ForEach(export.CumulativeExporter, records.AddRecord))
require.EqualValues(t, map[string]float64{
"counter/A=B/": 10,
@ -56,7 +57,7 @@ func TestPullNoCache(t *testing.T) {
require.NoError(t, puller.Collect(ctx))
records = test.NewOutput(label.DefaultEncoder())
require.NoError(t, puller.ForEach(records.AddRecord))
require.NoError(t, puller.ForEach(export.CumulativeExporter, records.AddRecord))
require.EqualValues(t, map[string]float64{
"counter/A=B/": 20,
@ -66,8 +67,8 @@ func TestPullNoCache(t *testing.T) {
func TestPullWithCache(t *testing.T) {
puller := pull.New(
selector.NewWithExactDistribution(),
export.CumulativeExporter,
pull.WithCachePeriod(time.Second),
pull.WithStateful(true),
)
mock := controllerTest.NewMockClock()
puller.SetClock(mock)
@ -80,7 +81,7 @@ func TestPullWithCache(t *testing.T) {
require.NoError(t, puller.Collect(ctx))
records := test.NewOutput(label.DefaultEncoder())
require.NoError(t, puller.ForEach(records.AddRecord))
require.NoError(t, puller.ForEach(export.CumulativeExporter, records.AddRecord))
require.EqualValues(t, map[string]float64{
"counter/A=B/": 10,
@ -91,7 +92,7 @@ func TestPullWithCache(t *testing.T) {
// Cached value!
require.NoError(t, puller.Collect(ctx))
records = test.NewOutput(label.DefaultEncoder())
require.NoError(t, puller.ForEach(records.AddRecord))
require.NoError(t, puller.ForEach(export.CumulativeExporter, records.AddRecord))
require.EqualValues(t, map[string]float64{
"counter/A=B/": 10,
@ -103,7 +104,7 @@ func TestPullWithCache(t *testing.T) {
// Re-computed value!
require.NoError(t, puller.Collect(ctx))
records = test.NewOutput(label.DefaultEncoder())
require.NoError(t, puller.ForEach(records.AddRecord))
require.NoError(t, puller.ForEach(export.CumulativeExporter, records.AddRecord))
require.EqualValues(t, map[string]float64{
"counter/A=B/": 20,