go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-12-01 23:12:29 +02:00
Code Issues Releases Activity

rename finish to end (#150)

Browse Source 
* rename finish -> end

* missed a few finish -> end spots

* change end back to finish for the bridge span in the openTracing bridge

* fixed grammar, ran make
This commit is contained in:
Alyson van Hardenberg
2019-09-27 10:48:10 -07:00
committed by rghetia
parent e86b95c440
commit 0eb73325ce
25 changed files with 93 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
api/trace/api.go
View File

@@ -46,15 +46,15 @@ type Tracer interface {
WithResources(res ...core.KeyValue) Tracer
}
type FinishOptions struct {
FinishTime time.Time
type EndOptions struct {
EndTime time.Time
}
type FinishOption func(*FinishOptions)
type EndOption func(*EndOptions)
func WithFinishTime(finishTime time.Time) FinishOption {
return func(opts *FinishOptions) {
opts.FinishTime = finishTime
func WithEndTime(endTime time.Time) EndOption {
return func(opts *EndOptions) {
opts.EndTime = endTime
}
}
@@ -62,9 +62,9 @@ type Span interface {
// Tracer returns tracer used to create this span. Tracer cannot be nil.
Tracer() Tracer
// Finish completes the span. No updates are allowed to span after it
// finishes. The only exception is setting status of the span.
Finish(options ...FinishOption)
// End completes the span. No updates are allowed to span after it
// ends. The only exception is setting status of the span.
End(options ...EndOption)
// AddEvent adds an event to the span.
AddEvent(ctx context.Context, msg string, attrs ...core.KeyValue)
@@ -82,12 +82,12 @@ type Span interface {
// It then adds the newly created Link to the span.
Link(sc core.SpanContext, attrs ...core.KeyValue)
// SpancContext returns span context of the span. Return SpanContext is usable
// even after the span is finished.
// SpanContext returns span context of the span. Returned SpanContext is usable
// even after the span ends.
SpanContext() core.SpanContext
// SetStatus sets the status of the span. The status of the span can be updated
// even after span is finished.
// even after span ends.
SetStatus(codes.Code)
// SetName sets the name of the span.