go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-27 22:49:15 +02:00
Code Issues Releases Activity

rename finish to end (#150)

Browse Source 
* rename finish -> end

* missed a few finish -> end spots

* change end back to finish for the bridge span in the openTracing bridge

* fixed grammar, ran make
This commit is contained in:
Alyson van Hardenberg
2019-09-27 10:48:10 -07:00
committed by rghetia
parent e86b95c440
commit 0eb73325ce
25 changed files with 93 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
experimental/streaming/sdk/span_test.go
View File

@@ -89,7 +89,7 @@ func TestCustomStartEndTime(t *testing.T) {
"testspan",
trace.WithStartTime(startTime),
)
span.Finish(trace.WithFinishTime(endTime))
span.End(trace.WithEndTime(endTime))
want := []exporter.Event{
{
Type: exporter.START_SPAN,
@@ -97,11 +97,11 @@ func TestCustomStartEndTime(t *testing.T) {
String: "testspan",
},
{
Type: exporter.FINISH_SPAN,
Type: exporter.END_SPAN,
Time: endTime,
},
}
got := append(obs.Events(exporter.START_SPAN), obs.Events(exporter.FINISH_SPAN)...)
got := append(obs.Events(exporter.START_SPAN), obs.Events(exporter.END_SPAN)...)
diffEvents(t, got, want, "Scope")
}