diff --git a/CHANGELOG.md b/CHANGELOG.md index 1dee8e73a..d3e958385 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Apply the value length limits to `Record` attributes in `go.opentelemetry.io/otel/sdk/log`. (#5230) - De-duplicate map attributes added to a `Record` in `go.opentelemetry.io/otel/sdk/log`. (#5230) - The `go.opentelemetry.io/otel/exporters/stdout/stdoutlog` exporter won't print `AttributeValueLengthLimit` and `AttributeCountLimit` fields now, instead it prints the `DroppedAttributes` field. (#5272) +- Improved performance in the `Stringer` implementation of `go.opentelemetry.io/otel/baggage.Member` by reducing the number of allocations. (#5286) ## [1.26.0/0.48.0/0.2.0-alpha] 2024-04-24 diff --git a/baggage/baggage.go b/baggage/baggage.go index 75773bc1c..f98c54a3c 100644 --- a/baggage/baggage.go +++ b/baggage/baggage.go @@ -335,9 +335,9 @@ func (m Member) String() string { // A key is just an ASCII string. A value is restricted to be // US-ASCII characters excluding CTLs, whitespace, // DQUOTE, comma, semicolon, and backslash. - s := fmt.Sprintf("%s%s%s", m.key, keyValueDelimiter, valueEscape(m.value)) + s := m.key + keyValueDelimiter + valueEscape(m.value) if len(m.properties) > 0 { - s = fmt.Sprintf("%s%s%s", s, propertyDelimiter, m.properties.String()) + s += propertyDelimiter + m.properties.String() } return s } diff --git a/baggage/baggage_test.go b/baggage/baggage_test.go index e8f67761f..9ed18791a 100644 --- a/baggage/baggage_test.go +++ b/baggage/baggage_test.go @@ -1027,3 +1027,18 @@ func BenchmarkValueEscape(b *testing.B) { }) } } + +func BenchmarkMemberString(b *testing.B) { + alphabet := "abcdefghijklmnopqrstuvwxyz" + props := make([]Property, len(alphabet)) + for i, r := range alphabet { + props[i] = Property{key: string(r)} + } + member, err := NewMember(alphabet, alphabet, props...) + require.NoError(b, err) + b.ReportAllocs() + b.ResetTimer() + for i := 0; i < b.N; i++ { + _ = member.String() + } +}