go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-04-13 11:30:31 +02:00
Code Issues Releases Activity

Change default Sampler to ParentOrElse(AlwaysOn) (#989)

Browse Source 
* Change default Sampler to ParentOrElse(AlwaysOn)

* add note to changelog
This commit is contained in:
MitchellDumovic 2020-07-29 19:10:12 -07:00 committed by GitHub
parent fa883d426b
commit 12992106de
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -64,6 +64,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Non-nil value `struct`s for key-value pairs will be marshalled using JSON rather than `Sprintf`. (#948)
### Changed
- Changed the default Sampler to `ParentOrElse(AlwaysOn)`. (#989)
### Removed
- Removed dependency on `github.com/open-telemetry/opentelemetry-collector`. (#943)

2
sdk/trace/provider.go
View File

@ -67,7 +67,7 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) {
namedTracer: make(map[instrumentation.Library]*tracer),
}
tp.config.Store(&Config{
DefaultSampler: AlwaysSample(),
DefaultSampler: ParentSample(AlwaysSample()),
IDGenerator: defIDGenerator(),
MaxAttributesPerSpan: DefaultMaxAttributesPerSpan,
MaxEventsPerSpan: DefaultMaxEventsPerSpan,