1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-15 01:04:25 +02:00

Consistently use pointer receivers for core.Number (#375)

Change all occurrences of value to pointer receivers
Add meta sys files to .gitignore
Code cleanup e.g.
- Don't capitalize error statements
- Fix ignored errors
- Fix ambiguous variable naming
- Remove unnecessary type casting
- Use named params

Fix #306
This commit is contained in:
Jonas-Taha El Sesiy
2019-12-09 13:03:11 -08:00
committed by rghetia
parent 30795ef58c
commit 1ab645fedb
33 changed files with 103 additions and 95 deletions

View File

@ -40,7 +40,7 @@ func TestValue(t *testing.T) {
name: "Key.Float64() correctly returns keys's internal float64 value",
value: k.Float64(42.1).Value,
wantType: core.FLOAT64,
wantValue: float64(42.1),
wantValue: 42.1,
},
{
name: "Key.Int32() correctly returns keys's internal int32 value",