go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-07 00:35:52 +02:00
Code Issues Releases Activity

Consistently use pointer receivers for core.Number (#375)

Browse Source 
Change all occurrences of value to pointer receivers
Add meta sys files to .gitignore
Code cleanup e.g.
- Don't capitalize error statements
- Fix ignored errors
- Fix ambiguous variable naming
- Remove unnecessary type casting
- Use named params

Fix #306
This commit is contained in:
Jonas-Taha El Sesiy
2019-12-09 13:03:11 -08:00
committed by rghetia
parent 30795ef58c
commit 1ab645fedb
33 changed files with 103 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/metric/aggregator/array/array_test.go
View File

@ -58,12 +58,13 @@ func (ut *updateTest) run(t *testing.T, profile test.Profile) {
all.Sort()
sum, err := agg.Sum()
require.Nil(t, err)
allSum := all.Sum()
require.InEpsilon(t,
all.Sum().CoerceToFloat64(profile.NumberKind),
(&allSum).CoerceToFloat64(profile.NumberKind),
sum.CoerceToFloat64(profile.NumberKind),
0.0000001,
"Same sum - absolute")
require.Nil(t, err)
count, err := agg.Count()
require.Nil(t, err)
require.Equal(t, all.Count(), count, "Same count - absolute")
@ -144,12 +145,13 @@ func (mt *mergeTest) run(t *testing.T, profile test.Profile) {
all.Sort()
sum, err := agg1.Sum()
require.Nil(t, err)
allSum := all.Sum()
require.InEpsilon(t,
all.Sum().CoerceToFloat64(profile.NumberKind),
(&allSum).CoerceToFloat64(profile.NumberKind),
sum.CoerceToFloat64(profile.NumberKind),
0.0000001,
"Same sum - absolute")
require.Nil(t, err)
count, err := agg1.Count()
require.Nil(t, err)
require.Equal(t, all.Count(), count, "Same count - absolute")
@ -287,8 +289,9 @@ func TestArrayFloat64(t *testing.T) {
all.Sort()
sum, err := agg.Sum()
require.InEpsilon(t, all.Sum().AsFloat64(), sum.AsFloat64(), 0.0000001, "Same sum")
require.Nil(t, err)
allSum := all.Sum()
require.InEpsilon(t, (&allSum).AsFloat64(), sum.AsFloat64(), 0.0000001, "Same sum")
count, err := agg.Count()
require.Equal(t, all.Count(), count, "Same count")