mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-03-11 14:49:19 +02:00
Ask for changelog updates with PRs (#879)
* Ask for changelog updates with PRs * Add PR ID to changelog entry * move changelog entry to unreleased
This commit is contained in:
parent
01b6452652
commit
2635f96eba
@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Changed
|
||||
|
||||
- Update `CONTRIBUTING.md` to ask for updates to `CHANGELOG.md` with each pull request. (#879)
|
||||
|
||||
## [0.7.0] - 2020-06-26
|
||||
|
||||
This release implements the v0.5.0 version of the OpenTelemetry specification.
|
||||
|
@ -67,19 +67,21 @@ Enter the newly created directory and add your fork as a new remote:
|
||||
$ git remote add <YOUR_FORK> git@github.com:<YOUR_GITHUB_USERNAME>/opentelemetry-go
|
||||
```
|
||||
|
||||
Check out a new branch, make modifications, run linters and tests, and
|
||||
push the branch to your fork:
|
||||
Check out a new branch, make modifications, run linters and tests, update
|
||||
`CHANGELOG.md`, and push the branch to your fork:
|
||||
|
||||
```sh
|
||||
$ git checkout -b <YOUR_BRANCH_NAME>
|
||||
# edit files
|
||||
# update changelog
|
||||
$ make precommit
|
||||
$ git add -p
|
||||
$ git commit
|
||||
$ git push <YOUR_FORK> <YOUR_BRANCH_NAME>
|
||||
```
|
||||
|
||||
Open a pull request against the main `opentelemetry-go` repo.
|
||||
Open a pull request against the main `opentelemetry-go` repo. Be sure to add the pull
|
||||
request ID to the entry you added to `CHANGELOG.md`.
|
||||
|
||||
### How to Receive Comments
|
||||
|
||||
@ -99,6 +101,8 @@ A PR is considered to be **ready to merge** when:
|
||||
people reasonable time to review.
|
||||
* Trivial change (typo, cosmetic, doc, etc.) doesn't have to wait for
|
||||
one day.
|
||||
* `CHANGELOG.md` has been updated to reflect what has been
|
||||
added, changed, removed, or fixed.
|
||||
* Urgent fix can take exception as long as it has been actively
|
||||
communicated.
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user