go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-13 01:00:22 +02:00
Code Issues Releases Activity

Remove WithSpan method from Tracer interface (#1043)

Browse Source 
* Remove WithSpan method from Tracer interface

Also remove implementation in SDK.

* Add panic event reporting to span End

* Update Changelog with changes

* Update CHANGELOG.md

* Update README.md

Fix code tabs

* Refactor span End

* Fix un-ended span from feedback.
This commit is contained in:
Tyler Yahn
2020-08-08 12:10:36 -07:00
committed by GitHub
parent f9ba15f2d1
commit 2dfa5e4fe1
19 changed files with 113 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
example/basic/main.go
View File

@ -67,11 +67,13 @@ func main() {
valuerecorder := valuerecorderTwo.Bind(commonLabels...)
defer valuerecorder.Unbind()
err = tracer.WithSpan(ctx, "operation", func(ctx context.Context) error {
err = func(ctx context.Context) error {
var span trace.Span
ctx, span = tracer.Start(ctx, "operation")
defer span.End()
trace.SpanFromContext(ctx).AddEvent(ctx, "Nice operation!", kv.Key("bogons").Int(100))
trace.SpanFromContext(ctx).SetAttributes(anotherKey.String("yes"))
span.AddEvent(ctx, "Nice operation!", kv.Key("bogons").Int(100))
span.SetAttributes(anotherKey.String("yes"))
meter.RecordBatch(
// Note: call-site variables added as context Entries:
@ -81,20 +83,18 @@ func main() {
valuerecorderTwo.Measurement(2.0),
)
return tracer.WithSpan(
ctx,
"Sub operation...",
func(ctx context.Context) error {
trace.SpanFromContext(ctx).SetAttributes(lemonsKey.String("five"))
return func(ctx context.Context) error {
var span trace.Span
ctx, span = tracer.Start(ctx, "Sub operation...")
defer span.End()
trace.SpanFromContext(ctx).AddEvent(ctx, "Sub span event")
span.SetAttributes(lemonsKey.String("five"))
span.AddEvent(ctx, "Sub span event")
valuerecorder.Record(ctx, 1.3)
valuerecorder.Record(ctx, 1.3)
return nil
},
)
})
return nil
}(ctx)
}(ctx)
if err != nil {
panic(err)
}