From 2efa30feec68b30f294c591492aff3e1f7852b39 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Tue, 2 Jun 2020 12:43:01 -0700 Subject: [PATCH] Error on span name set with uninitialized --- sdk/trace/span.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/trace/span.go b/sdk/trace/span.go index 9d9ae3c81..a3f8a5aa0 100644 --- a/sdk/trace/span.go +++ b/sdk/trace/span.go @@ -23,6 +23,7 @@ import ( "google.golang.org/grpc/codes" + "go.opentelemetry.io/otel/api/global" "go.opentelemetry.io/otel/api/kv" apitrace "go.opentelemetry.io/otel/api/trace" export "go.opentelemetry.io/otel/sdk/export/trace" @@ -205,7 +206,7 @@ func (s *span) SetName(name string) { defer s.mu.Unlock() if s.data == nil { - // TODO: now what? + global.Handle(fmt.Errorf("failed to set name on uninitialized span: %#v", s)) return } s.data.Name = name