1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-27 22:49:15 +02:00

Remove BYTES values, as they are are not thread safe (#249)

* Remove BYTES values, as they are mutable

* Remove more BYTES
This commit is contained in:
Joshua MacDonald
2019-10-30 10:20:53 -07:00
committed by GitHub
parent a2f3dcaf9a
commit 320c62a780
11 changed files with 11 additions and 86 deletions

View File

@@ -99,9 +99,8 @@ func BenchmarkSpanWithAttributes_all(b *testing.B) {
key.New("key6").Uint32(123),
key.New("key7").Float64(123.456),
key.New("key8").Float32(123.456),
key.New("key9").Bytes([]byte{1, 2, 3, 4}),
key.New("key10").Int(123),
key.New("key11").Uint(123),
key.New("key9").Int(123),
key.New("key10").Uint(123),
)
span.End()
}
@@ -125,7 +124,6 @@ func BenchmarkSpanWithAttributes_all_2x(b *testing.B) {
key.New("key6").Uint32(123),
key.New("key7").Float64(123.456),
key.New("key8").Float32(123.456),
key.New("key9").Bytes([]byte{1, 2, 3, 4}),
key.New("key10").Int(123),
key.New("key11").Uint(123),
key.New("key21").Bool(false),
@@ -136,7 +134,6 @@ func BenchmarkSpanWithAttributes_all_2x(b *testing.B) {
key.New("key26").Uint32(123),
key.New("key27").Float64(123.456),
key.New("key28").Float32(123.456),
key.New("key29").Bytes([]byte{1, 2, 3, 4}),
key.New("key210").Int(123),
key.New("key211").Uint(123),
)