go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-30 04:40:41 +02:00
Code Issues Releases Activity

s/HTTPUrlKey/HTTPURLKey/ in semconv (#1338)

Browse Source 
* s/HTTPUrlKey/HTTPURLKey/ in semconv

* Fix build

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This commit is contained in:
Ross Light 2020-11-16 09:55:25 -08:00 committed by GitHub
parent 3d6e8b5078
commit 380d9455fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -48,6 +48,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- The prometheus exporter now exports non-monotonic counters (i.e. `UpDownCounter`s) as gauges. (#1210) - The prometheus exporter now exports non-monotonic counters (i.e. `UpDownCounter`s) as gauges. (#1210)
- Correct the `Span.End` method documentation in the `otel` API to state updates are not allowed on a span after it has ended. (#1310) - Correct the `Span.End` method documentation in the `otel` API to state updates are not allowed on a span after it has ended. (#1310)
- Updated span collection limits for attribute, event and link counts to 1000 (#1318) - Updated span collection limits for attribute, event and link counts to 1000 (#1318)
- Renamed `semconv.HTTPUrlKey` to `semconv.HTTPURLKey`. (#1338)
### Removed ### Removed

2
semconv/http.go
View File

@ -140,7 +140,7 @@ func HTTPClientAttributesFromHTTPRequest(request *http.Request) []label.KeyValue
attrs = append(attrs, HTTPMethodKey.String(http.MethodGet)) attrs = append(attrs, HTTPMethodKey.String(http.MethodGet))
} }
attrs = append(attrs, HTTPUrlKey.String(request.URL.String())) attrs = append(attrs, HTTPURLKey.String(request.URL.String()))
return append(attrs, httpCommonAttributesFromHTTPRequest(request)...) return append(attrs, httpCommonAttributesFromHTTPRequest(request)...)
} }

2
semconv/trace.go
View File

@ -80,7 +80,7 @@ const (
// Full HTTP request URL in the form: // Full HTTP request URL in the form:
// scheme://host[:port]/path?query[#fragment]. // scheme://host[:port]/path?query[#fragment].
HTTPUrlKey = label.Key("http.url") HTTPURLKey = label.Key("http.url")
// The full request target as passed in a HTTP request line or // The full request target as passed in a HTTP request line or
// equivalent, e.g. "/path/12314/?q=ddds#123". // equivalent, e.g. "/path/12314/?q=ddds#123".