go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-17 01:12:45 +02:00
Code Issues Releases Activity

change the api/core tests to use core_testing package (#96)

Browse Source 
* add exported value for traceOptionBitMaskUnused (for testing)

* move key_test to package core_test

* add span_context_test to package core_test
This commit is contained in:
Dave Josephsen
2019-08-22 13:40:15 -05:00
committed by rghetia
parent 8d93efab11
commit 3ca747f4e8
3 changed files with 157 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

93
api/core/span_context_test.go
View File

@ -12,38 +12,45 @@
// See the License for the specific language governing permissions and
// limitations under the License.
package core
package core_test
import (
"testing"
"go.opentelemetry.io/api/core"
)
func TestIsValid(t *testing.T) {
for _, testcase := range []struct {
name string
tid TraceID
tid core.TraceID
sid uint64
want bool
}{
{
name: "bothTrue",
tid: TraceID{High: uint64(42)},
name: "SpanContext.IsValid() returns true if sc has both an Trace ID and Span ID",
tid: core.TraceID{High: uint64(42)},
sid: uint64(42),
want: true,
}, {
name: "bothFalse",
tid: TraceID{High: uint64(0)},
name: "SpanContext.IsValid() returns false if sc has neither an Trace ID nor Span ID",
tid: core.TraceID{High: uint64(0)},
sid: uint64(0),
want: false,
}, {
name: "oneTrue",
tid: TraceID{High: uint64(0)},
name: "SpanContext.IsValid() returns false if sc has a Span ID but not a Trace ID",
tid: core.TraceID{High: uint64(0)},
sid: uint64(42),
want: false,
}, {
name: "SpanContext.IsValid() returns false if sc has a Trace ID but not a Span ID",
tid: core.TraceID{High: uint64(42)},
sid: uint64(0),
want: false,
},
} {
t.Run(testcase.name, func(t *testing.T) {
sc := SpanContext{
sc := core.SpanContext{
TraceID: testcase.tid,
SpanID: testcase.sid,
}
@ -58,30 +65,30 @@ func TestIsValid(t *testing.T) {
func TestHasTraceID(t *testing.T) {
for _, testcase := range []struct {
name string
tid TraceID
tid core.TraceID
want bool
}{
{
name: "both",
tid: TraceID{High: uint64(42), Low: uint64(42)},
name: "SpanContext.HasTraceID() returns true if both Low and High are nonzero",
tid: core.TraceID{High: uint64(42), Low: uint64(42)},
want: true,
}, {
name: "neither",
tid: TraceID{},
name: "SpanContext.HasTraceID() returns false if neither Low nor High are nonzero",
tid: core.TraceID{},
want: false,
}, {
name: "high",
tid: TraceID{High: uint64(42)},
name: "SpanContext.HasTraceID() returns true if High != 0",
tid: core.TraceID{High: uint64(42)},
want: true,
}, {
name: "low",
tid: TraceID{Low: uint64(42)},
name: "SpanContext.HasTraceID() returns true if Low != 0",
tid: core.TraceID{Low: uint64(42)},
want: true,
},
} {
t.Run(testcase.name, func(t *testing.T) {
//proto: func (sc SpanContext) HasTraceID() bool{}
sc := SpanContext{TraceID: testcase.tid}
sc := core.SpanContext{TraceID: testcase.tid}
have := sc.HasTraceID()
if have != testcase.want {
t.Errorf("Want: %v, but have: %v", testcase.want, have)
@ -93,16 +100,16 @@ func TestHasTraceID(t *testing.T) {
func TestHasSpanID(t *testing.T) {
for _, testcase := range []struct {
name string
sc SpanContext
sc core.SpanContext
want bool
}{
{
name: "has",
sc: SpanContext{SpanID: uint64(42)},
name: "SpanContext.HasSpanID() returns true if self.SpanID != 0",
sc: core.SpanContext{SpanID: uint64(42)},
want: true,
}, {
name: "hasnt",
sc: SpanContext{},
name: "SpanContext.HasSpanID() returns false if self.SpanID == 0",
sc: core.SpanContext{},
want: false,
},
} {
@ -119,16 +126,16 @@ func TestHasSpanID(t *testing.T) {
func TestSpanIDString(t *testing.T) {
for _, testcase := range []struct {
name string
sc SpanContext
sc core.SpanContext
want string
}{
{
name: "fourtytwo",
sc: SpanContext{SpanID: uint64(42)},
name: "SpanContext.SpanIDString returns string representation of self.TraceID values > 0",
sc: core.SpanContext{SpanID: uint64(42)},
want: `000000000000002a`,
}, {
name: "empty",
sc: SpanContext{},
name: "SpanContext.SpanIDString returns string representation of self.TraceID values == 0",
sc: core.SpanContext{},
want: `0000000000000000`,
},
} {
@ -145,21 +152,21 @@ func TestSpanIDString(t *testing.T) {
func TestTraceIDString(t *testing.T) {
for _, testcase := range []struct {
name string
sc SpanContext
sc core.SpanContext
want string
}{
{
name: "fourtytwo",
sc: SpanContext{
TraceID: TraceID{
name: "SpanContext.TraceIDString returns string representation of self.TraceID values > 0",
sc: core.SpanContext{
TraceID: core.TraceID{
High: uint64(42),
Low: uint64(42),
},
},
want: `000000000000002a000000000000002a`,
}, {
name: "empty",
sc: SpanContext{TraceID: TraceID{}},
name: "SpanContext.TraceIDString returns string representation of self.TraceID values == 0",
sc: core.SpanContext{TraceID: core.TraceID{}},
want: `00000000000000000000000000000000`,
},
} {
@ -176,32 +183,32 @@ func TestTraceIDString(t *testing.T) {
func TestSpanContextIsSampled(t *testing.T) {
for _, testcase := range []struct {
name string
sc SpanContext
sc core.SpanContext
want bool
}{
{
name: "sampled",
sc: SpanContext{
TraceID: TraceID{
sc: core.SpanContext{
TraceID: core.TraceID{
High: uint64(42),
Low: uint64(42),
},
TraceOptions: TraceOptionSampled,
TraceOptions: core.TraceOptionSampled,
},
want: true,
}, {
name: "sampled plus unused",
sc: SpanContext{
TraceID: TraceID{
sc: core.SpanContext{
TraceID: core.TraceID{
High: uint64(42),
Low: uint64(42),
},
TraceOptions: TraceOptionSampled | traceOptionBitMaskUnused,
TraceOptions: core.TraceOptionSampled | core.TraceOptionUnused,
},
want: true,
}, {
name: "not sampled/default",
sc: SpanContext{TraceID: TraceID{}},
sc: core.SpanContext{TraceID: core.TraceID{}},
want: false,
},
} {