go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-03-03 14:52:56 +02:00
Code Issues Releases Activity

nit: Change metrics configs to have funcs on pointers (#2451)

Browse Source 
This avoids copying the whole object, also consistent with trace.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This commit is contained in:
Bogdan Drutu 2021-12-14 13:15:53 -08:00 committed by GitHub
parent db762533f9
commit 44bb795e78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
metric/config.go
View File

@ -25,12 +25,12 @@ type InstrumentConfig struct {
} }
// Description describes the instrument in human-readable terms. // Description describes the instrument in human-readable terms.
func (cfg InstrumentConfig) Description() string { func (cfg *InstrumentConfig) Description() string {
return cfg.description return cfg.description
} }
// Unit describes the measurement unit for a instrument. // Unit describes the measurement unit for a instrument.
func (cfg InstrumentConfig) Unit() unit.Unit { func (cfg *InstrumentConfig) Unit() unit.Unit {
return cfg.unit return cfg.unit
} }
@ -78,12 +78,12 @@ type MeterConfig struct {
} }
// InstrumentationVersion is the version of the library providing instrumentation. // InstrumentationVersion is the version of the library providing instrumentation.
func (cfg MeterConfig) InstrumentationVersion() string { func (cfg *MeterConfig) InstrumentationVersion() string {
return cfg.instrumentationVersion return cfg.instrumentationVersion
} }
// SchemaURL is the schema_url of the library providing instrumentation. // SchemaURL is the schema_url of the library providing instrumentation.
func (cfg MeterConfig) SchemaURL() string { func (cfg *MeterConfig) SchemaURL() string {
return cfg.schemaURL return cfg.schemaURL
} }