go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-06 09:09:44 +02:00
Code Issues Releases Activity

Move exemplar types to non-internal package (#5747)

Browse Source 
Part of https://github.com/open-telemetry/opentelemetry-go/issues/5249

This makes all existing types designed to implement the public Exemplar
API public by moving most of `internal/exemplar` to `exemplar`. The only
types that are not being made public are `exemplar.Drop`, and
`exemplar.FilteredReservoir`. Those types are moved to
`internal/aggregate`, and are renamed to `DropReservoir` and
`FilteredExemplarReservoir`.

The following types are made public:

* `exemplar.Exemplar`
* `exemplar.Filter`
* `exemplar.SampledFilter`
* `exemplar.AlwaysOnFilter`
* `exemplar.HistogramReservoir`
* `exemplar.FixedSizeReservoir`
* `exemplar.Reservoir`
* `exemplar.Value`
* `exemplar.ValueType`
This commit is contained in:
David Ashpole
2024-09-26 16:25:05 -04:00
committed by GitHub
parent 6edc7a63df
commit 481f4983f7
29 changed files with 214 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sdk/metric/internal/aggregate/aggregate_test.go
View File

@@ -13,7 +13,6 @@ import (
"github.com/stretchr/testify/assert"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/sdk/metric/internal/exemplar"
"go.opentelemetry.io/otel/sdk/metric/metricdata"
"go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest"
)
@@ -73,8 +72,8 @@ func (c *clock) Register() (unregister func()) {
return func() { now = orig }
}
func dropExemplars[N int64 | float64]() exemplar.FilteredReservoir[N] {
return exemplar.Drop[N]()
func dropExemplars[N int64 | float64]() FilteredExemplarReservoir[N] {
return DropReservoir[N]()
}
func TestBuilderFilter(t *testing.T) {