From 57a248d37518dde41f2fc11de09114280f7515f5 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Tue, 12 Apr 2022 17:04:06 -0700 Subject: [PATCH] Replace markdown link check action with script (#2785) * Replace markdown link check action with script * Add change to changelog * Fix spelling error in CHANGELOG --- .github/workflows/markdown.yml | 23 +++++++++++++++-------- CHANGELOG.md | 4 ++++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/workflows/markdown.yml b/.github/workflows/markdown.yml index ff8ddc1d9..92a8b8727 100644 --- a/.github/workflows/markdown.yml +++ b/.github/workflows/markdown.yml @@ -35,16 +35,23 @@ jobs: check-links: runs-on: ubuntu-latest + needs: changedfiles + if: ${{needs.changedfiles.outputs.md}} steps: - name: Checkout Repo uses: actions/checkout@v3 with: fetch-depth: 0 - - uses: gaurav-nelson/github-action-markdown-link-check@v1 - with: - base-branch: 'main' - use-quiet-mode: 'yes' - use-verbose-mode: 'yes' - config-file: '.markdown-link.json' - check-modified-files-only: 'yes' - folder-path: '' + # This doesn't use gaurav-nelson/github-action-markdown-link-check + # intentionally. As of v1.0.13 the base image was not pinned to a LTS + # version of node and updates upstream to the base image caused CI + # failures. This boils down the entrypoint script from that repository + # and calls markdown-link-check directly instead. + - name: Install markdown-link-check + run: npm install -g markdown-link-check + - name: Run markdown-link-check + run: | + markdown-link-check \ + --verbose \ + --config .markdown-link.json \ + ${{needs.changedfiles.outputs.md}} diff --git a/CHANGELOG.md b/CHANGELOG.md index 8a4a020f0..23a4d7e8e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ## [Unreleased] +### Fixed + +- Resolve supply-chain failure for the markdown-link-checker GitHub action by calling the CLI directly. (#2834) + ## [0.29.0] - 2022-04-11 ### Added