1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-02-01 13:07:51 +02:00

httptrace calls arrive async/threaded. (#113)

This commit is contained in:
Liz Fong-Jones 2019-09-12 19:40:58 -04:00 committed by rghetia
parent 9f85824979
commit 5df3c071e8

View File

@ -17,9 +17,11 @@ package httptrace
import (
"context"
"crypto/tls"
"fmt"
"net/http/httptrace"
"net/textproto"
"strings"
"sync"
"google.golang.org/grpc/codes"
@ -28,11 +30,6 @@ import (
"go.opentelemetry.io/api/trace"
)
type clientLevel struct {
trace.Span
ident string
}
var (
HTTPStatus = key.New("http.status")
HTTPHeaderMIME = key.New("http.mime")
@ -47,12 +44,15 @@ type clientTracer struct {
context.Context
httptrace.ClientTrace
levels []clientLevel
levels map[string]trace.Span
root trace.Span
mtx sync.Mutex
}
func newClientTracer(ctx context.Context) *clientTracer {
ct := &clientTracer{
Context: ctx,
levels: make(map[string]trace.Span),
}
ct.open("http.request")
return ct
@ -60,30 +60,29 @@ func newClientTracer(ctx context.Context) *clientTracer {
func (ct *clientTracer) open(name string, attrs ...core.KeyValue) {
_, sp := trace.Start(ct.Context, name, trace.WithAttributes(attrs...))
ct.levels = append(ct.levels, clientLevel{
Span: sp,
ident: name,
})
ct.mtx.Lock()
defer ct.mtx.Unlock()
if ct.root == nil {
ct.root = sp
}
ct.levels[name] = sp
}
func (ct *clientTracer) close(name string) {
if len(ct.levels) == 0 {
panic("remove me")
ct.mtx.Lock()
defer ct.mtx.Unlock()
if s, ok := ct.levels[name]; ok {
s.Finish()
delete(ct.levels, name)
} else {
panic(fmt.Sprintf("failed to find span %s in levels.", name))
}
l := len(ct.levels)
ct.levels[l-1].Finish()
ct.levels = ct.levels[0 : l-1]
}
func (ct *clientTracer) current() trace.Span {
return ct.levels[len(ct.levels)-1].Span
}
func (ct *clientTracer) currentName() string {
if len(ct.levels) == 0 {
return ""
}
return ct.levels[len(ct.levels)-1].ident
func (ct *clientTracer) span(name string) trace.Span {
ct.mtx.Lock()
defer ct.mtx.Unlock()
return ct.levels[name]
}
func (ct *clientTracer) getConn(host string) {
@ -91,16 +90,16 @@ func (ct *clientTracer) getConn(host string) {
}
func (ct *clientTracer) gotConn(info httptrace.GotConnInfo) {
ct.current().SetAttribute(HTTPRemoteAddr.String(info.Conn.RemoteAddr().String()))
ct.current().SetAttribute(HTTPLocalAddr.String(info.Conn.LocalAddr().String()))
ct.span("http.getconn").SetAttribute(HTTPRemoteAddr.String(info.Conn.RemoteAddr().String()))
ct.span("http.getconn").SetAttribute(HTTPLocalAddr.String(info.Conn.LocalAddr().String()))
ct.close("http.getconn")
}
func (ct *clientTracer) putIdleConn(err error) {
if err != nil {
ct.current().SetAttribute(MessageKey.String(err.Error()))
ct.current().SetStatus(codes.Unknown)
ct.span("http.receive").SetAttribute(MessageKey.String(err.Error()))
ct.span("http.receive").SetStatus(codes.Unknown)
}
ct.close("http.receive")
}
@ -134,10 +133,10 @@ func (ct *clientTracer) tlsHandshakeDone(tls.ConnectionState, error) {
}
func (ct *clientTracer) wroteHeaderField(k string, v []string) {
if ct.currentName() != "http.headers" {
if ct.span("http.headers") == nil {
ct.open("http.headers")
}
ct.levels[0].SetAttribute(key.New("http." + strings.ToLower(k)).String(sa2s(v)))
ct.root.SetAttribute(key.New("http." + strings.ToLower(k)).String(sa2s(v)))
}
func (ct *clientTracer) wroteHeaders() {
@ -146,22 +145,22 @@ func (ct *clientTracer) wroteHeaders() {
func (ct *clientTracer) wroteRequest(info httptrace.WroteRequestInfo) {
if info.Err != nil {
ct.levels[0].SetAttribute(MessageKey.String(info.Err.Error()))
ct.levels[0].SetStatus(codes.Unknown)
ct.root.SetAttribute(MessageKey.String(info.Err.Error()))
ct.root.SetStatus(codes.Unknown)
}
ct.close("http.send")
}
func (ct *clientTracer) got100Continue() {
ct.current().AddEvent(ct.Context, "GOT 100 - Continue")
ct.span("http.receive").AddEvent(ct.Context, "GOT 100 - Continue")
}
func (ct *clientTracer) wait100Continue() {
ct.current().AddEvent(ct.Context, "GOT 100 - Wait")
ct.span("http.receive").AddEvent(ct.Context, "GOT 100 - Wait")
}
func (ct *clientTracer) got1xxResponse(code int, header textproto.MIMEHeader) error {
ct.current().AddEvent(ct.Context, "GOT 1xx",
ct.span("http.receive").AddEvent(ct.Context, "GOT 1xx",
HTTPStatus.Int(code),
HTTPHeaderMIME.String(sm2s(header)),
)