go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-25 22:41:46 +02:00
Code Issues Releases Activity

Remove "HTTP" from propagator names (#355)

Browse Source 
These propagators are actually multi-purpose, not strictly for HTTP.
This commit is contained in:
Isobel Redelmeier
2019-11-25 23:05:07 -08:00
committed by rghetia
parent 13cd2ac417
commit 5f776dbaed
9 changed files with 39 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugin/othttp/handler.go
View File

@@ -80,7 +80,7 @@ func WithPublicEndpoint() Option {
// WithPropagator configures the Handler with a specific propagator. If this
// option isn't specificed then
// go.opentelemetry.io/otel/propagation.HTTPTraceContextPropagator is used.
// go.opentelemetry.io/otel/propagation.TraceContextPropagator is used.
func WithPropagator(p propagation.TextFormatPropagator) Option {
return func(h *Handler) {
h.prop = p
@@ -131,7 +131,7 @@ func NewHandler(handler http.Handler, operation string, opts ...Option) http.Han
h := Handler{handler: handler, operation: operation}
defaultOpts := []Option{
WithTracer(global.TraceProvider().Tracer("go.opentelemetry.io/plugin/othttp")),
WithPropagator(prop.HTTPTraceContextPropagator{}),
WithPropagator(prop.TraceContextPropagator{}),
WithSpanOptions(trace.WithSpanKind(trace.SpanKindServer)),
}