go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-23 22:34:47 +02:00
Code Issues Releases Activity

Change ClientResponse to accept an *http.Response (#3617)

Browse Source
This commit is contained in:
Tyler Yahn
2023-01-26 09:21:55 -08:00
committed by GitHub
parent c0fb8dec4c
commit 604772dda3
8 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/tools/semconvkit/templates/httpconv/http.go.tmpl
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }

2
semconv/internal/v2/http.go
View File

@@ -53,7 +53,7 @@ type HTTPConv struct {
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func (c *HTTPConv) ClientResponse(resp http.Response) []attribute.KeyValue { func (c *HTTPConv) ClientResponse(resp *http.Response) []attribute.KeyValue {
var n int var n int
if resp.StatusCode > 0 { if resp.StatusCode > 0 {
n++ n++

2
semconv/internal/v2/http_test.go
View File

@@ -47,7 +47,7 @@ var hc = &HTTPConv{
func TestHTTPClientResponse(t *testing.T) { func TestHTTPClientResponse(t *testing.T) {
const stat, n = 201, 397 const stat, n = 201, 397
resp := http.Response{ resp := &http.Response{
StatusCode: stat, StatusCode: stat,
ContentLength: n, ContentLength: n,
} }

2
semconv/v1.13.0/httpconv/http.go
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }

2
semconv/v1.14.0/httpconv/http.go
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }

2
semconv/v1.15.0/httpconv/http.go
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }

2
semconv/v1.16.0/httpconv/http.go
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }

2
semconv/v1.17.0/httpconv/http.go
View File

@@ -68,7 +68,7 @@ var (
// request contained in resp. For example: // request contained in resp. For example:
// //
// append(ClientResponse(resp), ClientRequest(resp.Request)...) // append(ClientResponse(resp), ClientRequest(resp.Request)...)
func ClientResponse(resp http.Response) []attribute.KeyValue { func ClientResponse(resp *http.Response) []attribute.KeyValue {
return hc.ClientResponse(resp) return hc.ClientResponse(resp)
} }