1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-02-09 13:37:12 +02:00

zipkin: remove no-op WithSDKOptions (#2248)

This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb119d59de101dba898fd02604b989734089.
This commit is contained in:
Andrei Matei 2021-09-20 11:59:17 -04:00 committed by GitHub
parent 568e7556dd
commit 61839133f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 9 deletions

View File

@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Removed
- Removed the zipkin.WithSDKOptions function. It already didn't have any effect (#2248).
- Removed the deprecated package `go.opentelemetry.io/otel/oteltest`. (#2234)
- Removed the deprecated package `go.opentelemetry.io/otel/bridge/opencensus/utils`. (#2233)
- Removed deprecated functions, types, and methods from `go.opentelemetry.io/otel/attribute` package.

View File

@ -43,7 +43,6 @@ func initTracer(url string) func() {
exporter, err := zipkin.New(
url,
zipkin.WithLogger(logger),
zipkin.WithSDKOptions(sdktrace.WithSampler(sdktrace.AlwaysSample())),
)
if err != nil {
log.Fatal(err)

View File

@ -49,7 +49,6 @@ var (
type config struct {
client *http.Client
logger *log.Logger
tpOpts []sdktrace.TracerProviderOption
}
// Option defines a function that configures the exporter.
@ -77,13 +76,6 @@ func WithClient(client *http.Client) Option {
})
}
// WithSDKOptions configures options passed to the created TracerProvider.
func WithSDKOptions(tpOpts ...sdktrace.TracerProviderOption) Option {
return optionFunc(func(cfg *config) {
cfg.tpOpts = tpOpts
})
}
// New creates a new Zipkin exporter.
func New(collectorURL string, opts ...Option) (*Exporter, error) {
if collectorURL == "" {