go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-08-10 22:31:50 +02:00
Code Issues Releases Activity

Clarify comments for the WithRetry option in exporters (#6670)

Browse Source 
It's been a while since I last looked at the comment about retries.
After re-reading it, I initially assumed the gRPC retry logic was
handled by the gRPC library itself, but it's actually implemented in our
code.

Update the comment to make it clearer.
This commit is contained in:
Sam Xie
2025-04-17 01:23:45 -07:00
committed by GitHub
parent 3107d5cb91
commit 6b977112b8
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
exporters/otlp/otlplog/otlploggrpc/config.go
View File

@@ -360,8 +360,9 @@ func WithTimeout(duration time.Duration) Option {
// explicitly returns a backoff time in the response, that time will take // explicitly returns a backoff time in the response, that time will take
// precedence over these settings. // precedence over these settings.
// //
// These settings do not define any network retry strategy. That is entirely // These settings define the retry strategy implemented by the exporter.
// handled by the gRPC ClientConn. // These settings do not define any network retry strategy.
// That is handled by the gRPC ClientConn.
// //
// If unset, the default retry policy will be used. It will retry the export // If unset, the default retry policy will be used. It will retry the export
// 5 seconds after receiving a retryable error and increase exponentially // 5 seconds after receiving a retryable error and increase exponentially

5
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go
View File

@@ -238,8 +238,9 @@ func WithTimeout(duration time.Duration) Option {
// explicitly returns a backoff time in the response, that time will take // explicitly returns a backoff time in the response, that time will take
// precedence over these settings. // precedence over these settings.
// //
// These settings do not define any network retry strategy. That is entirely // These settings define the retry strategy implemented by the exporter.
// handled by the gRPC ClientConn. // These settings do not define any network retry strategy.
// That is handled by the gRPC ClientConn.
// //
// If unset, the default retry policy will be used. It will retry the export // If unset, the default retry policy will be used. It will retry the export
// 5 seconds after receiving a retryable error and increase exponentially // 5 seconds after receiving a retryable error and increase exponentially

5
exporters/otlp/otlptrace/otlptracegrpc/options.go
View File

@@ -199,8 +199,9 @@ func WithTimeout(duration time.Duration) Option {
// explicitly returns a backoff time in the response. That time will take // explicitly returns a backoff time in the response. That time will take
// precedence over these settings. // precedence over these settings.
// //
// These settings do not define any network retry strategy. That is entirely // These settings define the retry strategy implemented by the exporter.
// handled by the gRPC ClientConn. // These settings do not define any network retry strategy.
// That is handled by the gRPC ClientConn.
// //
// If unset, the default retry policy will be used. It will retry the export // If unset, the default retry policy will be used. It will retry the export
// 5 seconds after receiving a retryable error and increase exponentially // 5 seconds after receiving a retryable error and increase exponentially