go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-04-15 11:36:44 +02:00
Code Issues Releases Activity

update jaeger exporter to translate resources to tags. (#551)

Browse Source
This commit is contained in:
Rahul Patel 2020-03-16 16:38:21 -07:00 committed by GitHub
parent 2ef25ea570
commit 74a528520b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
exporters/trace/jaeger/jaeger.go
View File

@ -204,6 +204,17 @@ func spanDataToThrift(data *export.SpanData) *gen.Span {
}
}
// TODO (rghetia): what to do if a resource key is the same as one of the attribute's key
// TODO (rghetia): is there a need for prefixing keys with "resource-"?
if data.Resource != nil {
for _, kv := range data.Resource.Attributes() {
tag := keyValueToTag(kv)
if tag != nil {
tags = append(tags, tag)
}
}
}
tags = append(tags,
getInt64Tag("status.code", int64(data.StatusCode)),
getStringTag("status.message", data.StatusMessage),

17
exporters/trace/jaeger/jaeger_test.go
View File

@ -21,20 +21,18 @@ import (
"testing"
"time"
"go.opentelemetry.io/otel/api/global"
"go.opentelemetry.io/otel/api/key"
apitrace "go.opentelemetry.io/otel/api/trace"
"github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/assert"
"google.golang.org/grpc/codes"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
"go.opentelemetry.io/otel/api/core"
"go.opentelemetry.io/otel/api/global"
"go.opentelemetry.io/otel/api/key"
apitrace "go.opentelemetry.io/otel/api/trace"
gen "go.opentelemetry.io/otel/exporters/trace/jaeger/internal/gen-go/jaeger"
export "go.opentelemetry.io/otel/sdk/export/trace"
"go.opentelemetry.io/otel/sdk/resource"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
)
func TestNewExporterPipelineWithRegistration(t *testing.T) {
@ -206,6 +204,8 @@ func Test_spanDataToThrift(t *testing.T) {
boolTrue := true
statusMessage := "this is a problem"
spanKind := "client"
rv1 := "rv11"
rv2 := int64(5)
tests := []struct {
name string
@ -242,6 +242,7 @@ func Test_spanDataToThrift(t *testing.T) {
StatusCode: codes.Unknown,
StatusMessage: statusMessage,
SpanKind: apitrace.SpanKindClient,
Resource: resource.New(core.Key("rk1").String(rv1), core.Key("rk2").Int64(rv2)),
},
want: &gen.Span{
TraceIdLow: 651345242494996240,
@ -257,6 +258,8 @@ func Test_spanDataToThrift(t *testing.T) {
{Key: "status.code", VType: gen.TagType_LONG, VLong: &statusCodeValue},
{Key: "status.message", VType: gen.TagType_STRING, VStr: &statusMessage},
{Key: "span.kind", VType: gen.TagType_STRING, VStr: &spanKind},
{Key: "rk1", VType: gen.TagType_STRING, VStr: &rv1},
{Key: "rk2", VType: gen.TagType_LONG, VLong: &rv2},
},
References: []*gen.SpanRef{
{