go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2024-12-30 21:20:04 +02:00
Code Issues Releases Activity

Minor change: ParentSampler -> ParentBased in Zipkin example description (#1171)

Browse Source 
* ParentSampler -> ParentBased in Zipkin example description

* update CHANGELOG
This commit is contained in:
Matej Gera 2020-09-13 20:45:46 +02:00 committed by GitHub
parent 6f048eb832
commit 77de1998cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -40,6 +40,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
recommend the use of `newConfig()` instead of `configure()`. (#1163)
- The `otlp.Config` type has been unexported and changed to `otlp.config`, along with its initializer. (#1163)
### Fixed
- Zipkin example no longer mentions `ParentSampler`, corrected to `ParentBased`. (#1171)
## [0.11.0] - 2020-08-24
### Added

2
example/zipkin/main.go
View File

@ -36,7 +36,7 @@ func initTracer(url string) {
// Create Zipkin Exporter and install it as a global tracer.
//
// For demoing purposes, always sample. In a production application, you should
// configure the sampler to a trace.ParentSampler(trace.TraceIDRatioBased) set at the desired
// configure the sampler to a trace.ParentBased(trace.TraceIDRatioBased) set at the desired
// ratio.
err := zipkin.InstallNewPipeline(
url,