go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-29 23:07:45 +02:00
Code Issues Releases Activity

Support a global MeterProvider in go.opentelemetry.io/otel (#3818)

Browse Source 
* Move ErrorHandler impl to internal

To avoid the import cycle, the otel/metric package needs to not import
otel. To achieve this, the error handling implementation is moved to the
otel/internal/global package where both can import the needed
functionality.

* Add global metric to go.opentelemetry.io/otel

* Crosslink and update to global metric in otel

* Add changes to changelog

* Set PR number in changelog

* Add global metric unit tests

* Rename MeterProivder() to GetMeterProivder()

* Add TODO to remove nolint comments
This commit is contained in:
Tyler Yahn
2023-03-01 11:16:03 -08:00
committed by GitHub
parent c39e625cdf
commit 813936187e
33 changed files with 554 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/metric/example_test.go
View File

@@ -18,7 +18,7 @@ import (
"context"
"log"
"go.opentelemetry.io/otel/metric/global"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/sdk/metric"
"go.opentelemetry.io/otel/sdk/resource"
semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
@@ -42,7 +42,7 @@ func Example() {
metric.WithResource(res),
metric.WithReader(reader),
)
global.SetMeterProvider(meterProvider)
otel.SetMeterProvider(meterProvider)
defer func() {
err := meterProvider.Shutdown(context.Background())
if err != nil {