From 875a25835fcfcddd61e94d87b1a0b14db4d5a0e5 Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Fri, 5 Mar 2021 22:25:58 +0000 Subject: [PATCH] Add docs on when reviews should be cleared (#1556) --- CONTRIBUTING.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2b31ccfec..2c38bd3f7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -100,7 +100,13 @@ A PR is considered to be **ready to merge** when: different companies). This is not enforced through technical means and a PR may be **ready to merge** with a single approval if the change and its approach have been discussed and consensus reached. -* Major feedbacks are resolved. +* Feedback has been addressed. +* Any substantive changes to your PR will require that you clear any prior + Approval reviews, this includes changes resulting from other feedback. Unless + the approver explicitly stated that their approval will persist across + changes it should be assumed that the PR needs their review again. Other + project members (e.g. approvers, maintainers) can help with this if there are + any questions or if you forget to clear reviews. * It has been open for review for at least one working day. This gives people reasonable time to review. * Trivial changes (typo, cosmetic, doc, etc.) do not have to wait for