From a6782b9ca99191da764ebd02b8da98d3c10d3887 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Wed, 16 Jul 2025 20:24:48 +0200 Subject: [PATCH] sdk/trace: remove unused version function (#7036) The unexported `version()` function in `sdk/trace` is not used anywhere. Not mentioning that the value it is returning is wrong. There is already a `Version` function in `sdk` (which is in the same Go module). --- sdk/trace/version.go | 9 --------- sdk/trace/version_test.go | 21 --------------------- 2 files changed, 30 deletions(-) delete mode 100644 sdk/trace/version.go delete mode 100644 sdk/trace/version_test.go diff --git a/sdk/trace/version.go b/sdk/trace/version.go deleted file mode 100644 index b84dd2c5e..000000000 --- a/sdk/trace/version.go +++ /dev/null @@ -1,9 +0,0 @@ -// Copyright The OpenTelemetry Authors -// SPDX-License-Identifier: Apache-2.0 - -package trace // import "go.opentelemetry.io/otel/sdk/trace" - -// version is the current release version of the metric SDK in use. -func version() string { - return "1.16.0-rc.1" -} diff --git a/sdk/trace/version_test.go b/sdk/trace/version_test.go deleted file mode 100644 index e2a353795..000000000 --- a/sdk/trace/version_test.go +++ /dev/null @@ -1,21 +0,0 @@ -// Copyright The OpenTelemetry Authors -// SPDX-License-Identifier: Apache-2.0 - -package trace - -import ( - "regexp" - "testing" - - "github.com/stretchr/testify/assert" -) - -var versionRegex = regexp.MustCompile(`^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)` + - `(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)` + - `(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?` + - `(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$`) - -func TestVersionSemver(t *testing.T) { - v := version() - assert.Regexp(t, versionRegex, v) -}