go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-27 22:49:15 +02:00
Code Issues Releases Activity

api(trace): change trace id to byte array. (#226)

Browse Source 
* api(trace): change trace id to byte array.

* fix lint errors

* add helper to create trace id from hex and improve stdout exporter.

* remove comma.

* fix lint

* change TraceIDFromHex to be compliant with w3 trace-context

* revert remove of hex16 regex because its used to parse SpanID

* lint

* fix typo
This commit is contained in:
Gustavo Silva Paiva
2019-10-23 03:01:33 -03:00
committed by rghetia
parent cf62d12648
commit a6e139e1d4
21 changed files with 209 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sdk/trace/batch_span_processor_test.go
View File

@@ -16,6 +16,7 @@ package trace_test
import (
"context"
"encoding/binary"
"sync"
"testing"
"time"
@@ -164,7 +165,7 @@ func TestNewBatchSpanProcessorWithOptions(t *testing.T) {
// Check first Span is reported. Most recent one is dropped.
sc := getSpanContext()
wantTraceID := sc.TraceID
wantTraceID.High = 1
binary.BigEndian.PutUint64(wantTraceID[0:8], uint64(1))
gotTraceID := te.get(0).SpanContext.TraceID
if wantTraceID != gotTraceID {
t.Errorf("%s: first exported span: got %+v, want %+v\n", option.name, gotTraceID, wantTraceID)
@@ -185,14 +186,14 @@ func generateSpan(t *testing.T, tr apitrace.Tracer, option testOption) {
sc := getSpanContext()
for i := 0; i < option.genNumSpans; i++ {
sc.TraceID.High = uint64(i + 1)
binary.BigEndian.PutUint64(sc.TraceID[0:8], uint64(i+1))
_, span := tr.Start(context.Background(), option.name, apitrace.ChildOf(sc))
span.End()
}
}
func getSpanContext() core.SpanContext {
tid := core.TraceID{High: 0x0102030405060708, Low: 0x0102040810203040}
tid, _ := core.TraceIDFromHex("01020304050607080102040810203040")
sid := uint64(0x0102040810203040)
return core.SpanContext{
TraceID: tid,