go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-04-04 22:14:17 +02:00
Code Issues Releases Activity

refactor: use Key's Defined method (#2593)

Browse Source 
* optimize(attribute): use Key's Defined method

* Update kv.go
This commit is contained in:
yellow chicks 2022-02-11 08:41:34 +08:00 committed by GitHub
parent 010ca4f2b1
commit b01dc21f6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
attribute/kv.go
View File

@ -26,7 +26,7 @@ type KeyValue struct {
// Valid returns if kv is a valid OpenTelemetry attribute. // Valid returns if kv is a valid OpenTelemetry attribute.
func (kv KeyValue) Valid() bool { func (kv KeyValue) Valid() bool {
return kv.Key != "" && kv.Value.Type() != INVALID return kv.Key.Defined() && kv.Value.Type() != INVALID
} }
// Bool creates a KeyValue with a BOOL Value type. // Bool creates a KeyValue with a BOOL Value type.