go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-25 22:41:46 +02:00
Code Issues Releases Activity

Remove Synchronous and rename Asynchronous (#3892)

Browse Source 
* Remove the Synchronous interface

* Rename Asynchronous to Observable

* Update PR number
This commit is contained in:
Tyler Yahn
2023-03-20 13:26:17 -07:00
committed by GitHub
parent 4ccd590569
commit b7b53bba40
19 changed files with 39 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sdk/metric/meter_test.go
View File

@@ -489,7 +489,7 @@ func TestRegisterNonSDKObserverErrors(t *testing.T) {
mp := NewMeterProvider(WithReader(rdr))
meter := mp.Meter("scope")
type obsrv struct{ instrument.Asynchronous }
type obsrv struct{ instrument.Observable }
o := obsrv{}
_, err := meter.RegisterCallback(
@@ -1254,7 +1254,7 @@ func testAttributeFilter(temporality metricdata.Temporality) func(*testing.T) {
}
}
func TestAsynchronousExample(t *testing.T) {
func TestObservableExample(t *testing.T) {
// This example can be found:
// https://github.com/open-telemetry/opentelemetry-specification/blob/8b91585e6175dd52b51e1d60bea105041225e35d/specification/metrics/supplementary-guidelines.md#asynchronous-example
var (
@@ -1277,7 +1277,7 @@ func TestAsynchronousExample(t *testing.T) {
const (
instName = "pageFaults"
filteredStream = "filteredPageFaults"
scopeName = "AsynchronousExample"
scopeName = "ObservableExample"
)
selector := func(InstrumentKind) metricdata.Temporality { return temp }