go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-25 22:41:46 +02:00
Code Issues Releases Activity

Fix span option typo in SDK span End, and WithAttributes only being available on span start (#6006)

Browse Source
This commit is contained in:
Damien Mathieu
2024-11-27 16:53:10 +01:00
committed by GitHub
parent 652588ddd9
commit bab246013b
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/trace/span.go
View File

@@ -438,8 +438,8 @@ func truncate(limit int, s string) string {
// End ends the span. This method does nothing if the span is already ended or // End ends the span. This method does nothing if the span is already ended or
// is not being recorded. // is not being recorded.
// //
// The only SpanOption currently supported is WithTimestamp which will set the // The only SpanEndOption currently supported are [trace.WithTimestamp], and
// end time for a Span's life-cycle. // [trace.WithStackTrace].
// //
// If this method is called while panicking an error event is added to the // If this method is called while panicking an error event is added to the
// Span before ending it and the panic is continued. // Span before ending it and the panic is continued.

2
trace/config.go
View File

@@ -213,7 +213,7 @@ var _ SpanStartEventOption = attributeOption{}
// WithAttributes adds the attributes related to a span life-cycle event. // WithAttributes adds the attributes related to a span life-cycle event.
// These attributes are used to describe the work a Span represents when this // These attributes are used to describe the work a Span represents when this
// option is provided to a Span's start or end events. Otherwise, these // option is provided to a Span's start event. Otherwise, these
// attributes provide additional information about the event being recorded // attributes provide additional information about the event being recorded
// (e.g. error, state change, processing progress, system event). // (e.g. error, state change, processing progress, system event).
// //