go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-05 00:28:58 +02:00
Code Issues Releases Activity

Vendor Thrift dependency (#1551)

Browse Source 
* Vendor Thrift dependency

* Fix build

* Changelog entry

* Ignore third_party for coverage purposes

* Re-run tests

* Re-run tests

* Re-run tests

* Re-run tests

* Relax time comparisons

Fixes #1559.

Some unit tests were flaking in CI because they expected the timestamp
to advance during a test, when it's possible for it to be unchanged
instead. This change switches the offending "<" comparisons to "<=".

* Re-run tests

* Relax more time comparisons

* Re-run tests

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This commit is contained in:
Punya Biswal
2021-02-19 13:12:35 -05:00
committed by GitHub
parent 298c5a142f
commit d7aff47338
59 changed files with 8502 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/metric/processor/basic/basic_test.go
View File

@ -335,8 +335,8 @@ func TestBasicTimestamps(t *testing.T) {
}))
// The first start time is set in the constructor.
require.True(t, beforeNew.Before(start1))
require.True(t, afterNew.After(start1))
require.False(t, beforeNew.After(start1))
require.False(t, afterNew.Before(start1))
for i := 0; i < 2; i++ {
b.StartCollection()