1
0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-03-05 15:05:51 +02:00

Cleanup sort

This commit is contained in:
jmacd 2020-05-21 10:46:22 -07:00
parent 9548817e7e
commit db993ec5cc

View File

@ -66,22 +66,16 @@ var _ aggregator.Histogram = &Aggregator{}
func New(desc *metric.Descriptor, boundaries []float64) *Aggregator {
// Boundaries MUST be ordered otherwise the histogram could not
// be properly computed.
// metric.SortNumbers(desc.NumberKind(), boundaries)
// sortedBoundaries := numbers{
// numbers: make([]metric.Number, len(boundaries)),
// kind: desc.NumberKind(),
// }
sort.Float64s(boundaries)
sortedBoundaries := make([]float64, len(boundaries))
// copy(sortedBoundaries.numbers, boundaries)
// sort.Sort(&sortedBoundaries)
// boundaries = sortedBoundaries.numbers
copy(sortedBoundaries, boundaries)
sort.Float64s(sortedBoundaries)
return &Aggregator{
kind: desc.NumberKind(),
boundaries: boundaries,
current: emptyState(boundaries),
checkpoint: emptyState(boundaries),
boundaries: sortedBoundaries,
current: emptyState(sortedBoundaries),
checkpoint: emptyState(sortedBoundaries),
}
}