go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-11-29 23:07:45 +02:00
Code Issues Releases Activity

feat(span): remove SetAttribute method (#1216)

Browse Source 
* feat(span): remove SetAttribute method

* Update CHANGELOG.md

Revert markdown lint changes and unify the `Removed` section.

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This commit is contained in:
Stanley Nguyen
2020-10-03 05:41:15 +08:00
committed by GitHub
parent 6e184cd16f
commit de50711fcc
8 changed files with 1 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sdk/trace/span.go
View File

@@ -101,13 +101,6 @@ func (s *span) SetAttributes(attributes ...label.KeyValue) {
s.copyToCappedAttributes(attributes...)
}
func (s *span) SetAttribute(k string, v interface{}) {
attr := label.Any(k, v)
if attr.Value.Type() != label.INVALID {
s.SetAttributes(attr)
}
}
// End ends the span.
//
// The only SpanOption currently supported is WithTimestamp which will set the