You've already forked opentelemetry-go
mirror of
https://github.com/open-telemetry/opentelemetry-go.git
synced 2025-07-13 01:00:22 +02:00
Combine the Push and Pull metric controllers (#1378)
* Push->basic * Repackage * Rename away from push * Make exporter optional; export from a separate goroutine * Move pull_test into controller_test * Precommit pass * New OTLP/Prom example * Precommit * Fix the example * Shorten the example * Test starting controller w/o exporter * Test export timeout * Remove ancient example & lint * go.mod revert & tidy * Comments * Tidy a diff * Tidy a diff * Move export kind selector in the new example * Split this test into its original parts * Reduce diff size * Changelog * Remove extra Add/Done pair * Remove unused stopCh param; document the Stop behavior * Typo * Use ctx * Missed v0.15 * Apply PR feedback * Precommit pass * 0.14 -> 0.15 in new file * Remove diff chunk markers * Fix OTLP example * Upstream * dashpole comments * aneurysm9 feedback * Tidy go.sum
This commit is contained in:
Joshua MacDonald
GitHub
230
sdk/metric/controller/basic/push_test.go
Normal file
230
sdk/metric/controller/basic/push_test.go
Normal file
@ -0,0 +1,230 @@
|
||||
// Copyright The OpenTelemetry Authors
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
package basic_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"fmt"
|
||||
"runtime"
|
||||
"sync"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"go.opentelemetry.io/otel"
|
||||
"go.opentelemetry.io/otel/label"
|
||||
"go.opentelemetry.io/otel/metric"
|
||||
export "go.opentelemetry.io/otel/sdk/export/metric"
|
||||
"go.opentelemetry.io/otel/sdk/export/metric/aggregation"
|
||||
controller "go.opentelemetry.io/otel/sdk/metric/controller/basic"
|
||||
"go.opentelemetry.io/otel/sdk/metric/controller/controllertest"
|
||||
processor "go.opentelemetry.io/otel/sdk/metric/processor/basic"
|
||||
"go.opentelemetry.io/otel/sdk/metric/processor/processortest"
|
||||
"go.opentelemetry.io/otel/sdk/resource"
|
||||
)
|
||||
|
||||
var testResource = resource.NewWithAttributes(label.String("R", "V"))
|
||||
|
||||
type handler struct {
|
||||
sync.Mutex
|
||||
err error
|
||||
}
|
||||
|
||||
func (h *handler) Handle(err error) {
|
||||
h.Lock()
|
||||
h.err = err
|
||||
h.Unlock()
|
||||
}
|
||||
|
||||
func (h *handler) Flush() error {
|
||||
h.Lock()
|
||||
err := h.err
|
||||
h.err = nil
|
||||
h.Unlock()
|
||||
return err
|
||||
}
|
||||
|
||||
var testHandler *handler
|
||||
|
||||
func init() {
|
||||
testHandler = new(handler)
|
||||
otel.SetErrorHandler(testHandler)
|
||||
}
|
||||
|
||||
func newExporter() *processortest.Exporter {
|
||||
return processortest.NewExporter(
|
||||
export.StatelessExportKindSelector(),
|
||||
label.DefaultEncoder(),
|
||||
)
|
||||
}
|
||||
|
||||
func newCheckpointer() export.Checkpointer {
|
||||
return processortest.Checkpointer(
|
||||
processortest.NewProcessor(
|
||||
processortest.AggregatorSelector(),
|
||||
label.DefaultEncoder(),
|
||||
),
|
||||
)
|
||||
}
|
||||
|
||||
func TestPushDoubleStop(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
exporter := newExporter()
|
||||
checkpointer := newCheckpointer()
|
||||
p := controller.New(checkpointer, controller.WithPusher(exporter))
|
||||
require.NoError(t, p.Start(ctx))
|
||||
require.NoError(t, p.Stop(ctx))
|
||||
require.NoError(t, p.Stop(ctx))
|
||||
}
|
||||
|
||||
func TestPushDoubleStart(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
exporter := newExporter()
|
||||
checkpointer := newCheckpointer()
|
||||
p := controller.New(checkpointer, controller.WithPusher(exporter))
|
||||
require.NoError(t, p.Start(ctx))
|
||||
err := p.Start(ctx)
|
||||
require.Error(t, err)
|
||||
require.True(t, errors.Is(err, controller.ErrControllerStarted))
|
||||
require.NoError(t, p.Stop(ctx))
|
||||
}
|
||||
|
||||
func TestPushTicker(t *testing.T) {
|
||||
exporter := newExporter()
|
||||
checkpointer := newCheckpointer()
|
||||
p := controller.New(
|
||||
checkpointer,
|
||||
controller.WithPusher(exporter),
|
||||
controller.WithCollectPeriod(time.Second),
|
||||
controller.WithResource(testResource),
|
||||
)
|
||||
meter := p.MeterProvider().Meter("name")
|
||||
|
||||
mock := controllertest.NewMockClock()
|
||||
p.SetClock(mock)
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
counter := metric.Must(meter).NewInt64Counter("counter.sum")
|
||||
|
||||
require.NoError(t, p.Start(ctx))
|
||||
|
||||
counter.Add(ctx, 3)
|
||||
|
||||
require.EqualValues(t, map[string]float64{}, exporter.Values())
|
||||
|
||||
mock.Add(time.Second)
|
||||
runtime.Gosched()
|
||||
|
||||
require.EqualValues(t, map[string]float64{
|
||||
"counter.sum//R=V": 3,
|
||||
}, exporter.Values())
|
||||
|
||||
require.Equal(t, 1, exporter.ExportCount())
|
||||
exporter.Reset()
|
||||
|
||||
counter.Add(ctx, 7)
|
||||
|
||||
mock.Add(time.Second)
|
||||
runtime.Gosched()
|
||||
|
||||
require.EqualValues(t, map[string]float64{
|
||||
"counter.sum//R=V": 10,
|
||||
}, exporter.Values())
|
||||
|
||||
require.Equal(t, 1, exporter.ExportCount())
|
||||
exporter.Reset()
|
||||
|
||||
require.NoError(t, p.Stop(ctx))
|
||||
}
|
||||
|
||||
func TestPushExportError(t *testing.T) {
|
||||
injector := func(name string, e error) func(r export.Record) error {
|
||||
return func(r export.Record) error {
|
||||
if r.Descriptor().Name() == name {
|
||||
return e
|
||||
}
|
||||
return nil
|
||||
}
|
||||
}
|
||||
var errAggregator = fmt.Errorf("unexpected error")
|
||||
var tests = []struct {
|
||||
name string
|
||||
injectedError error
|
||||
expected map[string]float64
|
||||
expectedError error
|
||||
}{
|
||||
{"errNone", nil, map[string]float64{
|
||||
"counter1.sum/X=Y/R=V": 3,
|
||||
"counter2.sum//R=V": 5,
|
||||
}, nil},
|
||||
{"errNoData", aggregation.ErrNoData, map[string]float64{
|
||||
"counter2.sum//R=V": 5,
|
||||
}, nil},
|
||||
{"errUnexpected", errAggregator, map[string]float64{}, errAggregator},
|
||||
}
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
exporter := newExporter()
|
||||
exporter.InjectErr = injector("counter1.sum", tt.injectedError)
|
||||
|
||||
// This test validates the error handling
|
||||
// behavior of the basic Processor is honored
|
||||
// by the push processor.
|
||||
checkpointer := processor.New(processortest.AggregatorSelector(), exporter)
|
||||
p := controller.New(
|
||||
checkpointer,
|
||||
controller.WithPusher(exporter),
|
||||
controller.WithCollectPeriod(time.Second),
|
||||
controller.WithResource(testResource),
|
||||
)
|
||||
|
||||
mock := controllertest.NewMockClock()
|
||||
p.SetClock(mock)
|
||||
|
||||
ctx := context.Background()
|
||||
|
||||
meter := p.MeterProvider().Meter("name")
|
||||
counter1 := metric.Must(meter).NewInt64Counter("counter1.sum")
|
||||
counter2 := metric.Must(meter).NewInt64Counter("counter2.sum")
|
||||
|
||||
require.NoError(t, p.Start(ctx))
|
||||
runtime.Gosched()
|
||||
|
||||
counter1.Add(ctx, 3, label.String("X", "Y"))
|
||||
counter2.Add(ctx, 5)
|
||||
|
||||
require.Equal(t, 0, exporter.ExportCount())
|
||||
require.Nil(t, testHandler.Flush())
|
||||
|
||||
mock.Add(time.Second)
|
||||
runtime.Gosched()
|
||||
|
||||
require.Equal(t, 1, exporter.ExportCount())
|
||||
if tt.expectedError == nil {
|
||||
require.EqualValues(t, tt.expected, exporter.Values())
|
||||
require.NoError(t, testHandler.Flush())
|
||||
} else {
|
||||
err := testHandler.Flush()
|
||||
require.Error(t, err)
|
||||
require.Equal(t, tt.expectedError, err)
|
||||
}
|
||||
|
||||
require.NoError(t, p.Stop(ctx))
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user