go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-15 01:04:25 +02:00
Code Issues Releases Activity

Rename SynchronizedCopy to SynchronizedMove and update comment (#858)

Browse Source
This commit is contained in:
Joshua MacDonald
2020-06-23 10:41:11 -07:00
committed by GitHub
parent d343f987f8
commit ea53fb4d1a
21 changed files with 67 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sdk/metric/aggregator/array/array.go
View File

@ -46,7 +46,7 @@ var _ aggregation.Points = &Aggregator{}
// New returns a new array aggregator, which aggregates recorded
// measurements by storing them in an array. This type uses a mutex
// for Update() and SynchronizedCopy() concurrency.
// for Update() and SynchronizedMove() concurrency.
func New(cnt int) []Aggregator {
return make([]Aggregator, cnt)
}
@ -92,9 +92,9 @@ func (c *Aggregator) Points() ([]metric.Number, error) {
return c.points, nil
}
// SynchronizedCopy saves the current state to oa and resets the current state to
// SynchronizedMove saves the current state to oa and resets the current state to
// the empty set, taking a lock to prevent concurrent Update() calls.
func (c *Aggregator) SynchronizedCopy(oa export.Aggregator, desc *metric.Descriptor) error {
func (c *Aggregator) SynchronizedMove(oa export.Aggregator, desc *metric.Descriptor) error {
o, _ := oa.(*Aggregator)
if o == nil {
return aggregator.NewInconsistentAggregatorError(c, oa)
@ -114,7 +114,7 @@ func (c *Aggregator) SynchronizedCopy(oa export.Aggregator, desc *metric.Descrip
}
// Update adds the recorded measurement to the current data set.
// Update takes a lock to prevent concurrent Update() and SynchronizedCopy()
// Update takes a lock to prevent concurrent Update() and SynchronizedMove()
// calls.
func (c *Aggregator) Update(_ context.Context, number metric.Number, desc *metric.Descriptor) error {
c.lock.Lock()