Rename otel/label -> otel/attribute (#1541)

* Rename otel/label -> otel/attr Leave the imported name alone, to avoid a large diff and conflicts * Better import comment * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * otel/attr -> otel/attribute * Missed the changelog entry * Get rid of import renaming * Merge remaining conflicts Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2025-11-27 22:49:15 +02:00 · 2021-02-18 12:59:37 -05:00
parent 1b5b662136
commit ecf65d7968
123 changed files with 1715 additions and 1715 deletions
--- a/attribute/kv_test.go
+++ b/attribute/kv_test.go
@@ -0,0 +1,162 @@
+// Copyright The OpenTelemetry Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package attribute_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/google/go-cmp/cmp"
+
+	"go.opentelemetry.io/otel/attribute"
+)
+
+func TestKeyValueConstructors(t *testing.T) {
+	tt := []struct {
+		name     string
+		actual   attribute.KeyValue
+		expected attribute.KeyValue
+	}{
+		{
+			name:   "Bool",
+			actual: attribute.Bool("k1", true),
+			expected: attribute.KeyValue{
+				Key:   "k1",
+				Value: attribute.BoolValue(true),
+			},
+		},
+		{
+			name:   "Int64",
+			actual: attribute.Int64("k1", 123),
+			expected: attribute.KeyValue{
+				Key:   "k1",
+				Value: attribute.Int64Value(123),
+			},
+		},
+		{
+			name:   "Float64",
+			actual: attribute.Float64("k1", 123.5),
+			expected: attribute.KeyValue{
+				Key:   "k1",
+				Value: attribute.Float64Value(123.5),
+			},
+		},
+		{
+			name:   "String",
+			actual: attribute.String("k1", "123.5"),
+			expected: attribute.KeyValue{
+				Key:   "k1",
+				Value: attribute.StringValue("123.5"),
+			},
+		},
+		{
+			name:   "Int",
+			actual: attribute.Int("k1", 123),
+			expected: attribute.KeyValue{
+				Key:   "k1",
+				Value: attribute.IntValue(123),
+			},
+		},
+	}
+
+	for _, test := range tt {
+		t.Run(test.name, func(t *testing.T) {
+			if diff := cmp.Diff(test.actual, test.expected, cmp.AllowUnexported(attribute.Value{})); diff != "" {
+				t.Fatal(diff)
+			}
+		})
+	}
+}
+
+func TestAny(t *testing.T) {
+	builder := &strings.Builder{}
+	builder.WriteString("foo")
+	jsonifyStruct := struct {
+		Public    string
+		private   string
+		Tagged    string `json:"tagName"`
+		Empty     string
+		OmitEmpty string `json:",omitempty"`
+		Omit      string `json:"-"`
+	}{"foo", "bar", "baz", "", "", "omitted"}
+	invalidStruct := struct {
+		N complex64
+	}{complex(0, 0)}
+	for _, testcase := range []struct {
+		key       string
+		value     interface{}
+		wantType  attribute.Type
+		wantValue interface{}
+	}{
+		{
+			key:       "bool type inferred",
+			value:     true,
+			wantType:  attribute.BOOL,
+			wantValue: true,
+		},
+		{
+			key:       "int64 type inferred",
+			value:     int64(42),
+			wantType:  attribute.INT64,
+			wantValue: int64(42),
+		},
+		{
+			key:       "float64 type inferred",
+			value:     float64(42.1),
+			wantType:  attribute.FLOAT64,
+			wantValue: 42.1,
+		},
+		{
+			key:       "string type inferred",
+			value:     "foo",
+			wantType:  attribute.STRING,
+			wantValue: "foo",
+		},
+		{
+			key:       "stringer type inferred",
+			value:     builder,
+			wantType:  attribute.STRING,
+			wantValue: "foo",
+		},
+		{
+			key:       "unknown value serialized as %v",
+			value:     nil,
+			wantType:  attribute.STRING,
+			wantValue: "<nil>",
+		},
+		{
+			key:       "JSON struct serialized correctly",
+			value:     &jsonifyStruct,
+			wantType:  attribute.STRING,
+			wantValue: `{"Public":"foo","tagName":"baz","Empty":""}`,
+		},
+		{
+			key:       "Invalid JSON struct falls back to string",
+			value:     &invalidStruct,
+			wantType:  attribute.STRING,
+			wantValue: "&{(0+0i)}",
+		},
+	} {
+		t.Logf("Running test case %s", testcase.key)
+		keyValue := attribute.Any(testcase.key, testcase.value)
+		if keyValue.Value.Type() != testcase.wantType {
+			t.Errorf("wrong value type, got %#v, expected %#v", keyValue.Value.Type(), testcase.wantType)
+		}
+		got := keyValue.Value.AsInterface()
+		if diff := cmp.Diff(testcase.wantValue, got); diff != "" {
+			t.Errorf("+got, -want: %s", diff)
+		}
+	}
+}