go/opentelemetry-go
go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-01-20 03:30:02 +02:00
Code Issues Releases Activity

Avoid one memory allocation in LabelSet construction (#318)

Browse Source
This commit is contained in:
Joshua MacDonald 2019-11-14 13:13:42 -08:00 committed by rghetia
parent 9d19d8296c
commit ee87858c09
1 changed files with 16 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sdk/metric/sdk.go
View File

@ -76,7 +76,7 @@ type (
// repeatedly.
labels struct {
meter *SDK
sorted []core.KeyValue
sorted sortedLabels
encoded string
}
@ -245,19 +245,23 @@ func (m *SDK) Labels(kvs ...core.KeyValue) api.LabelSet {
return &m.empty
}
ls := &labels{
meter: m,
sorted: kvs,
}
// Sort and de-duplicate.
sorted := sortedLabels(kvs)
sort.Stable(&sorted)
sort.Stable(&ls.sorted)
oi := 1
for i := 1; i < len(sorted); i++ {
if sorted[i-1].Key == sorted[i].Key {
sorted[oi-1] = sorted[i]
for i := 1; i < len(ls.sorted); i++ {
if ls.sorted[i-1].Key == ls.sorted[i].Key {
ls.sorted[oi-1] = ls.sorted[i]
continue
}
sorted[oi] = sorted[i]
ls.sorted[oi] = ls.sorted[i]
oi++
}
sorted = sorted[0:oi]
ls.sorted = ls.sorted[0:oi]
// Serialize.
buf := m.pool.Get().(*bytes.Buffer)
@ -265,7 +269,7 @@ func (m *SDK) Labels(kvs ...core.KeyValue) api.LabelSet {
buf.Reset()
_, _ = buf.WriteRune('|')
delimiter := '#'
for _, kv := range sorted {
for _, kv := range ls.sorted {
_, _ = buf.WriteRune(delimiter)
_, _ = buf.WriteString(string(kv.Key))
_, _ = buf.WriteRune(':')
@ -273,11 +277,9 @@ func (m *SDK) Labels(kvs ...core.KeyValue) api.LabelSet {
delimiter = ','
}
return &labels{
meter: m,
sorted: sorted,
encoded: buf.String(),
}
ls.encoded = buf.String()
return ls
}
// labsFor sanitizes the input LabelSet. The input will be rejected