From f290782ed2754cf8d70f08670fbf75d984904035 Mon Sep 17 00:00:00 2001 From: Sam Xie Date: Tue, 30 Jul 2024 23:05:42 -0700 Subject: [PATCH] Fix benchmark ci (#5657) Failed benchmark action: https://github.com/open-telemetry/opentelemetry-go/actions/runs/10168263116/job/28122471446 This is because of the OOM, as some of the benchmarks, like `BenchmarkSpanEnd`, require nearly 10 GiB in a live heap. Changes: - Increase the memory of the runner to 16 GiB. - Remove the timeout of this action, as this takes 22 minutes to complete on github public runner (https://github.com/XSAM/opentelemetry-go/actions/runs/10168013989/job/28121638433). The number of benchmarks could only increase in the future, so setting a hard limit seems not right. FYI, the resource of github runner for public repositories is also 4 cores 16 GiB. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories --- .github/workflows/benchmark.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 397576ae3..7a9bdecac 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -10,8 +10,7 @@ env: jobs: benchmark: name: Benchmarks - runs-on: actuated-arm64-4cpu-4gb - timeout-minutes: 15 + runs-on: actuated-arm64-4cpu-16gb steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5