go/opentelemetry-go
1
0
Fork 0
mirror of https://github.com/open-telemetry/opentelemetry-go.git synced 2025-07-15 01:04:25 +02:00
Code Issues Releases Activity

Unify api/label and api/kv in new label package (#1060)

Browse Source 
* Move `api/label` to `label`

* Move `api/kv` package contents into `label` package

* Unify label package name

* Move `api/internal/rawhelpers.go` to `internal`

* Propagate replacing `api/kv` with `label` pkg

* golint

* Fix over-aggressive change

* Update Changelog
This commit is contained in:
Tyler Yahn
2020-08-17 20:25:03 -07:00
committed by GitHub
parent e44c9dee78
commit f995380e58
112 changed files with 1582 additions and 1611 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
sdk/metric/controller/pull/pull_test.go
View File

@ -22,9 +22,8 @@ import (
"github.com/stretchr/testify/require"
"go.opentelemetry.io/otel/api/kv"
"go.opentelemetry.io/otel/api/label"
"go.opentelemetry.io/otel/api/metric"
"go.opentelemetry.io/otel/label"
export "go.opentelemetry.io/otel/sdk/export/metric"
"go.opentelemetry.io/otel/sdk/metric/controller/controllertest"
"go.opentelemetry.io/otel/sdk/metric/controller/pull"
@ -47,7 +46,7 @@ func TestPullNoCache(t *testing.T) {
meter := puller.Provider().Meter("nocache")
counter := metric.Must(meter).NewInt64Counter("counter.sum")
counter.Add(ctx, 10, kv.String("A", "B"))
counter.Add(ctx, 10, label.String("A", "B"))
require.NoError(t, puller.Collect(ctx))
records := processortest.NewOutput(label.DefaultEncoder())
@ -57,7 +56,7 @@ func TestPullNoCache(t *testing.T) {
"counter.sum/A=B/": 10,
}, records.Map())
counter.Add(ctx, 10, kv.String("A", "B"))
counter.Add(ctx, 10, label.String("A", "B"))
require.NoError(t, puller.Collect(ctx))
records = processortest.NewOutput(label.DefaultEncoder())
@ -84,7 +83,7 @@ func TestPullWithCache(t *testing.T) {
meter := puller.Provider().Meter("nocache")
counter := metric.Must(meter).NewInt64Counter("counter.sum")
counter.Add(ctx, 10, kv.String("A", "B"))
counter.Add(ctx, 10, label.String("A", "B"))
require.NoError(t, puller.Collect(ctx))
records := processortest.NewOutput(label.DefaultEncoder())
@ -94,7 +93,7 @@ func TestPullWithCache(t *testing.T) {
"counter.sum/A=B/": 10,
}, records.Map())
counter.Add(ctx, 10, kv.String("A", "B"))
counter.Add(ctx, 10, label.String("A", "B"))
// Cached value!
require.NoError(t, puller.Collect(ctx))