Tyler Yahn
1f5b159161
Use already enabled revive linter and add depguard ( #2883 )
...
* Refactor golangci-lint conf
Order settings alphabetically.
* Add revive settings to golangci conf
* Check blank imports
* Check bool-literal-in-expr
* Check constant-logical-expr
* Check context-as-argument
* Check context-key-type
* Check deep-exit
* Check defer
* Check dot-imports
* Check duplicated-imports
* Check early-return
* Check empty-block
* Check empty-lines
* Check error-naming
* Check error-return
* Check error-strings
* Check errorf
* Stop ignoring context first arg in tests
* Check exported comments
* Check flag-parameter
* Check identical branches
* Check if-return
* Check increment-decrement
* Check indent-error-flow
* Check deny list of go imports
* Check import shadowing
* Check package comments
* Check range
* Check range val in closure
* Check range val address
* Check redefines builtin id
* Check string-format
* Check struct tag
* Check superfluous else
* Check time equal
* Check var naming
* Check var declaration
* Check unconditional recursion
* Check unexported return
* Check unhandled errors
* Check unnecessary stmt
* Check unnecessary break
* Check waitgroup by value
* Exclude deep-exit check in example*_test.go files
2022-05-19 15:15:07 -05:00
Tyler Yahn
fdfc821bac
Add godot linter to golangci ( #2845 )
...
Comment should be complete sentences outside of lists with sentence
fragments. This adds the godot linter to check these complete sentences
end with punctuation. If they do not, running fix will append a period.
2022-04-25 13:22:49 -07:00
Tyler Yahn
b1c1e781e6
Support general attribute limits for spans ( #2677 )
...
* Support general attribute limits for spans
When model specific limits are not set fallback to the general ones
defined by environment variables before defaults for attribute length
and count limits. This is in compliance with the specification.
* Update env pkg unit tests
Test all environment variable helper functions.
* Add changes to changelog
* Update firstInt doc
2022-03-16 14:33:59 -07:00
Tyler Yahn
0d0a7320e6
Update span limits to comply with specification ( #2637 )
...
* PoC for span limit refactor
* Rename config.go to span_limits.go
* Add unit tests for truncateAttr
* Add unit tests for non-string attrs
* Add span limit benchmark tests
* Fix lint
* Isolate span limit tests
* Clean span limits test
* Test limits on exported spans
* Remove duplicate test code
* Fix lint
* Add WithRawSpanLimits option
* Add test for raw and orig span limits opts
* Add changes to changelog
* Add tests for span resource disabled
* Test unlimited instead of default limit
* Update docs
* Add fix to changelog
* Fix option docs
* Do no mutate attribute
* Fix truncateAttr comment
* Remake NewSpanLimits to be newEnvSpanLimits
Update and unify documentation accordingly.
* Update truncateAttr string slice update comment
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
2022-03-03 07:56:07 -08:00
Will Li
98c2c9d96c
Add env support for span limits configuration ( #2606 )
...
* add env support for otel_span configuration
Signed-off-by: Cuichen Li <cuichli@cisco.com>
* update changelog
* update changelog and some logic based on comment
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* add document about retrieve value from environment variable
Signed-off-by: Cuichen Li <cuichli@cisco.com>
* remove trailing whitespace
Signed-off-by: Cuichen Li <cuichli@cisco.com>
* parse environment variable before apply the options
* Update CHANGELOG.md
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update sdk/trace/provider_test.go
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update CHANGELOG.md
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
2022-02-17 08:21:13 -08:00
Tyler Yahn
b60d53d316
Unexport EnvBatchSpanProcessor* constants ( #2583 )
...
* Move BSP env support to internal
* Use pkg name
* Update env test
* Use internal/env in sdk/trace
2022-02-07 07:57:44 -08:00
