Tyler Yahn
442cdbdd94
Generate and upgrade to semconv/v1.41.0 ( #8324 )
...
Fix https://github.com/open-telemetry/opentelemetry-go/issues/8299
Relevant upstream v1.41.0 release notes:
> ### 🛑 Breaking changes 🛑
>
> - `graphql`: Change `graphql.document` attribute requirement level
from Recommended to Opt-In due to sensitive data, cardinality, and size
concerns
([#2985 ](https://github.com/open-telemetry/semantic-conventions/issues/2985 ))
> - `process`: Move process.executable to its own entity.
([#3535 ](https://github.com/open-telemetry/semantic-conventions/issues/3535 ))
> - `process`: Update requirement levels for process attributes to
ensure consistent identification and description across platforms.
([#864 ](https://github.com/open-telemetry/semantic-conventions/issues/864 ))
> - `rpc`: Remove `client.address` and `client.port` attributes from RPC
server spans.
([#3487 ](https://github.com/open-telemetry/semantic-conventions/issues/3487 ),
[#3488 ](https://github.com/open-telemetry/semantic-conventions/issues/3488 ))
>
> ### 💡 Enhancements 💡
>
> - `Go`: Add opt-in go.memory.gc.pause.duration histogram metric.
([#3353 ](https://github.com/open-telemetry/semantic-conventions/issues/3353 ))
> - `deployment`: Stabilize `deployment.environment.name` attribute.
([#3339 ](https://github.com/open-telemetry/semantic-conventions/issues/3339 ))
> - `deployment`: Add enum values for `deployment.environment.name`
attribute.
([#2910 ](https://github.com/open-telemetry/semantic-conventions/issues/2910 ))
> - `go`: Add the go.cpu.time opt-in metric, and add
go.cpu.detailed_state and go.memory.detailed_type attributes to CPU and
memory metrics respectively with wildcard values.
([#3354 ](https://github.com/open-telemetry/semantic-conventions/issues/3354 ))
> - `go`: Add the opt-in go.memory.gc.cycles metric.
([#3353 ](https://github.com/open-telemetry/semantic-conventions/issues/3353 ))
> - `telemetry`: Promote `telemetry.distro.name` and
`telemetry.distro.version` attributes to 'stable'.
([#3650 ](https://github.com/open-telemetry/semantic-conventions/issues/3650 ))
This PR also:
- fixes semconv migration generation to ignore unexported declarations
when computing renames/removals
- upgrades repo imports, depguard, docs, templates, and schema URL
expectations to `go.opentelemetry.io/otel/semconv/v1.41.0`
- adds missing generated-file headers to semconvkit templates and
regenerates the affected `v1.41.0` files via `TAG="v1.41.0" make
semconv-generate`
---------
Co-authored-by: David Ashpole <dashpole@google.com >
2026-05-14 14:06:05 -04:00
Mikhail Mazurskiy
c45d9a3301
fix: clear cached objects to enable GC ( #8233 )
...
There is a the same problem in the semconv package, but I'm not sure how
to regenerate those files.
Also,
[`ResourceMetrics`](https://github.com/open-telemetry/opentelemetry-go/blob/bec9f66b45ae1e679212285467572d132b627ff4/exporters/prometheus/exporter.go#L181 )
should be cleared too, but it's not. I wonder how things work today
because this object has a slice that keeps growing, doesn't it? I
decided not to touch it for now.
`sdk/metric.BenchmarkEndToEndCounterAdd` shows no change:
```
goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/sdk/metric
cpu: Apple M4 Max
│ before.txt │ after.txt │
│ sec/op │ sec/op vs base │
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributeSet-16 64.12n ± ∞ ¹ 63.45n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributes-16 62.82n ± ∞ ¹ 63.04n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributeSet-16 90.09n ± ∞ ¹ 81.45n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributes-16 90.15n ± ∞ ¹ 92.02n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Naive/WithAttributes-16 102.2n ± ∞ ¹ 102.4n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributeSet-16 61.13n ± ∞ ¹ 62.71n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributes-16 59.10n ± ∞ ¹ 61.69n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributeSet-16 144.4n ± ∞ ¹ 149.5n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributes-16 223.0n ± ∞ ¹ 223.3n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Naive/WithAttributes-16 277.8n ± ∞ ¹ 277.2n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributeSet-16 62.41n ± ∞ ¹ 59.82n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributes-16 65.09n ± ∞ ¹ 65.49n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributeSet-16 262.4n ± ∞ ¹ 270.1n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributes-16 392.8n ± ∞ ¹ 418.6n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Naive/WithAttributes-16 505.8n ± ∞ ¹ 523.3n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributeSet-16 77.02n ± ∞ ¹ 77.29n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributes-16 77.35n ± ∞ ¹ 77.34n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributeSet-16 94.47n ± ∞ ¹ 97.93n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributes-16 107.8n ± ∞ ¹ 110.4n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Naive/WithAttributes-16 121.4n ± ∞ ¹ 121.6n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributeSet-16 172.4n ± ∞ ¹ 169.0n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributes-16 165.7n ± ∞ ¹ 167.6n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributeSet-16 291.1n ± ∞ ¹ 294.8n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributes-16 355.7n ± ∞ ¹ 358.8n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Naive/WithAttributes-16 408.4n ± ∞ ¹ 402.2n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributeSet-16 321.4n ± ∞ ¹ 322.3n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributes-16 315.3n ± ∞ ¹ 314.9n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributeSet-16 557.3n ± ∞ ¹ 576.7n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributes-16 685.9n ± ∞ ¹ 712.2n ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Naive/WithAttributes-16 796.0n ± ∞ ¹ 809.4n ± ∞ ¹ ~ (p=1.000 n=1) ²
geomean 168.5n 170.0n +0.87%
¹ need >= 6 samples for confidence interval at level 0.95
² need >= 4 samples to detect a difference at alpha level 0.05
│ before.txt │ after.txt │
│ B/op │ B/op vs base │
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributeSet-16 88.00 ± ∞ ¹ 88.00 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributes-16 152.0 ± ∞ ¹ 152.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Naive/WithAttributes-16 232.0 ± ∞ ¹ 232.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributeSet-16 344.0 ± ∞ ¹ 344.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributes-16 665.0 ± ∞ ¹ 665.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Naive/WithAttributes-16 1000.0 ± ∞ ¹ 1000.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributeSet-16 729.0 ± ∞ ¹ 729.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributes-16 1.399Ki ± ∞ ¹ 1.400Ki ± ∞ ¹ ~ (p=1.000 n=1) ³
EndToEndCounterAdd/NoFilter/Attributes/10/Naive/WithAttributes-16 2.102Ki ± ∞ ¹ 2.102Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributeSet-16 64.00 ± ∞ ¹ 64.00 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributes-16 64.00 ± ∞ ¹ 64.00 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributeSet-16 152.0 ± ∞ ¹ 152.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributes-16 216.0 ± ∞ ¹ 216.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Naive/WithAttributes-16 296.0 ± ∞ ¹ 296.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributeSet-16 576.0 ± ∞ ¹ 576.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributes-16 576.0 ± ∞ ¹ 576.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributeSet-16 921.0 ± ∞ ¹ 921.0 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributes-16 1.212Ki ± ∞ ¹ 1.212Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Naive/WithAttributes-16 1.539Ki ± ∞ ¹ 1.539Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributeSet-16 1.312Ki ± ∞ ¹ 1.312Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributes-16 1.312Ki ± ∞ ¹ 1.312Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributeSet-16 2.025Ki ± ∞ ¹ 2.025Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributes-16 2.713Ki ± ∞ ¹ 2.714Ki ± ∞ ¹ ~ (p=1.000 n=1) ³
EndToEndCounterAdd/Filtered/Attributes/10/Naive/WithAttributes-16 3.414Ki ± ∞ ¹ 3.414Ki ± ∞ ¹ ~ (p=1.000 n=1) ²
geomean ⁴ +0.00% ⁴
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ need >= 4 samples to detect a difference at alpha level 0.05
⁴ summaries must be >0 to compute geomean
│ before.txt │ after.txt │
│ allocs/op │ allocs/op vs base │
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributeSet-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Dynamic/WithAttributes-16 3.000 ± ∞ ¹ 3.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/1/Naive/WithAttributes-16 5.000 ± ∞ ¹ 5.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributeSet-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Dynamic/WithAttributes-16 3.000 ± ∞ ¹ 3.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/5/Naive/WithAttributes-16 5.000 ± ∞ ¹ 5.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributeSet-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Precomputed/WithAttributes-16 0.000 ± ∞ ¹ 0.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributeSet-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Dynamic/WithAttributes-16 3.000 ± ∞ ¹ 3.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/NoFilter/Attributes/10/Naive/WithAttributes-16 5.000 ± ∞ ¹ 5.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributeSet-16 1.000 ± ∞ ¹ 1.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Precomputed/WithAttributes-16 1.000 ± ∞ ¹ 1.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributeSet-16 3.000 ± ∞ ¹ 3.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Dynamic/WithAttributes-16 4.000 ± ∞ ¹ 4.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/1/Naive/WithAttributes-16 6.000 ± ∞ ¹ 6.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributeSet-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Precomputed/WithAttributes-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributeSet-16 4.000 ± ∞ ¹ 4.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Dynamic/WithAttributes-16 5.000 ± ∞ ¹ 5.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/5/Naive/WithAttributes-16 7.000 ± ∞ ¹ 7.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributeSet-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Precomputed/WithAttributes-16 2.000 ± ∞ ¹ 2.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributeSet-16 4.000 ± ∞ ¹ 4.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Dynamic/WithAttributes-16 5.000 ± ∞ ¹ 5.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
EndToEndCounterAdd/Filtered/Attributes/10/Naive/WithAttributes-16 7.000 ± ∞ ¹ 7.000 ± ∞ ¹ ~ (p=1.000 n=1) ²
geomean ³ +0.00% ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean
```
---------
Co-authored-by: David Ashpole <dashpole@google.com >
2026-05-14 13:49:51 -04:00
Cijo Thomas
2f358df8e0
docs: Expand SIG meeting welcoming language ( #8319 )
...
Adds a welcoming paragraph to the CONTRIBUTING.md SIG meeting section,
matching the wording used in
[opentelemetry-rust](https://github.com/open-telemetry/opentelemetry-rust#contributing )
and
[opentelemetry-dotnet](https://github.com/open-telemetry/opentelemetry-dotnet#contributing ).
Per discussion in
[community#1805](https://github.com/open-telemetry/community/issues/1805 ).
2026-05-08 12:07:16 -07:00
David Ashpole
8899c97372
Update contributing to recommend using Enabled ( #8189 )
...
Fixes https://github.com/open-telemetry/opentelemetry-go/issues/7800
Updates CONTRIBUTING.md to recommend using Enabled for
self-observability metrics.
2026-04-14 10:38:15 -04:00
David Ashpole
28df982c8b
Add support for experimental options in the metrics API ( #8111 )
...
Part of https://github.com/open-telemetry/opentelemetry-go/issues/8110
Related to
https://github.com/open-telemetry/opentelemetry-go/issues/5882 .
I'm hoping to find a better way to support experimental Options types in
our API packages. This is one approach to consider.
This contains no public API changes. It introduces a type:
`ExperimentalOption` in `/metric/internal/x`, which can be used by our
experimental options defined outside of the module. Options that embed
this interface are ignored by `New*Config` builder functions in the
metrics API to prevent them from panicing when used. Only SDKs that
explicitly support the experimental option in question will respect it.
Alternative SDKs will ignore the experimental options. We would still
need to treat ExperimentalOption as a stable artifact, since the SDK
will indirectly depend on it.
See
https://github.com/open-telemetry/opentelemetry-go/compare/main...dashpole:opentelemetry-go:attributes_advisory
for how this would be used to support the advisory attributes parameter.
2026-04-03 15:56:57 -04:00
David Ashpole
9dab9bb36f
Document how to implement experimental features ( #8124 )
...
Fixes https://github.com/open-telemetry/opentelemetry-go/issues/5882 .
This intentionally doesn't include
https://github.com/open-telemetry/opentelemetry-go/pull/8111 , and just
documents what we had previously discussed, but never added to our docs.
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2026-04-03 14:11:36 -04:00
Tyler Yahn
5b5c2c5d6d
Upgrade to semconv/v1.40.0 ( #7991 )
2026-03-04 12:13:40 +01:00
Saharsh Tibrewala
61f0e4855c
Bump semconv from v1.37.0 to v1.39.0 ( #7789 )
...
Fixes #7788
---------
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2026-01-21 10:42:41 +01:00
Damien Mathieu
bc288672f3
Move scorpionknifes to emeritus ( #7526 )
...
Cheng-Zhen Yang has not had any activity in several months, and he
confirmed to me on slack that he can't contribute anymore and we should
move him to emeritus.
cc @scorpionknifes
---------
Co-authored-by: Flc゛ <i@flc.io >
2025-10-22 14:37:22 +02:00
Sebastien Dionne
1935e6012b
Fix typos and linguistic errors in documentation / hacktoberfest ( #7494 )
...
Fix typos and linguistic errors in documentation. It's not much, but I'm
happy to help
---------
Signed-off-by: Sebastien Dionne <survivant00@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2025-10-13 15:57:14 -07:00
Tyler Yahn
7fdebbe3ed
Rename Self-Observability as just Observability ( #7302 )
...
Self-Observability is a redundant term, the self being instrumented is
always the self that observability is being provided for. Remove this
redundancy.
Continue to provide backwards compatibility for any users already using
`OTEL_GO_X_SELF_OBSERVABILITY` to enable the feature.
---------
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2025-09-11 10:01:19 +02:00
Tyler Yahn
a5dcd68ebb
Add Observability section to CONTRIBUTING doc ( #7272 )
...
Adds an `Observability` section to the CONTRIBUTING.md documentation.
This is a follow-up to issue
https://github.com/open-telemetry/opentelemetry-go/issues/2547#issuecomment-3234179600
and provides guidance for implementing self-observability in
OpenTelemetry Go SDK components.
2025-09-04 09:09:12 -07:00
Tyler Yahn
97c22e37a4
Add security insights document to repository ( #7129 )
...
Resolve #6245
Resolve #6246
Resolve #6241
Add a "v1.0.0" security insights policy to the repository.
This does not add a "v2.0.0" version of the insights policy as the [CLO
monitor
documentation](https://clomonitor.io/docs/topics/checks/#security-insights )
still reference the "v1.0.0" policy. The policy can be updated if the
CLO tooling is also updated in the future.
2025-08-06 14:30:59 -07:00
Robert Pająk
d9e9038f07
Add Flc as an approver ( #7053 )
...
Flc has been doing excellent work in this SIG. He is consistently active
for more than a year:
https://github.com/flc1125?tab=overview&from=2025-06-01&org=open-telemetry .
I would like to nominate him as an approver.
---------
Co-authored-by: Damien Mathieu <42@dmathieu.com >
Co-authored-by: Sam Xie <sam@samxie.me >
2025-07-23 17:51:03 -07:00
Robert Pająk
ca02873ee4
docs: Add Go Code Review Comments and allow the use of testify ( #6984 )
...
Inspired by
https://github.com/open-telemetry/opentelemetry-go-contrib/pull/7522#discussion_r2190580677
I hope it will help new contributors. Also I want to codify that we are
OK when one uses `testify`, but I do not also want to force it (e.g.
https://github.com/open-telemetry/opentelemetry-go-contrib/pull/7522 was
not using it).
I think that as long as we use the standard library, `testify`, `go-cmp`
we are fine (and should not accept any other libraries than those).
2025-07-14 15:45:42 -07:00
Trask Stalnaker
d17046c4cf
Standardize sections listing maintainer, approver, etc ( #6942 )
...
Related to https://github.com/open-telemetry/community/issues/2830
Also related to https://github.com/open-telemetry/govanityurls/pull/20
(creates the anchor for the link in that PR)
2025-06-30 08:56:36 +02:00
OpenTelemetry Bot
4458a0086b
Fix outdated community membership link ( #6935 )
...
See https://github.com/open-telemetry/community/issues/2830 for details
(missed this on the first round)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com >
2025-06-26 17:09:33 -07:00
OpenTelemetry Bot
e6cc254b4e
Update community member listings ( #6931 )
...
See https://github.com/open-telemetry/community/issues/2830 for details
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
2025-06-25 10:08:00 +02:00
Robert Pająk
553779c161
chore: add missing ) in GPG hyperlink ( #6928 )
2025-06-24 17:10:52 +02:00
Tyler Yahn
4ebbbadc68
Add release artifacts signing to the release process ( #6855 )
...
Resolve #6854
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
Co-authored-by: Sam Xie <sam@samxie.me >
Co-authored-by: David Ashpole <dashpole@google.com >
2025-06-16 19:30:30 +02:00
Tyler Yahn
678d2f155d
Update the required approvals policy ( #6783 )
...
Based on SIG meeting discussions today: relax requirement for two
approvals from Approvers at different companies. Instead, require at
least one approver or the author to not work at the same company.
This means that if the author works at a different company than two
Approvers who have approved and work at the same company, the PR is
ready to merge.
This continues the enforcement that if an author and all Approvers
approving a PR work at the same company, additional qualified approvals
are needed.
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2025-05-22 07:50:12 -07:00
Damien Mathieu
3daca50ce2
Promote Alex Kats to triager ( #6420 )
...
As we discussed in yesterday's SIG meeting, this proposes to promote
@akats7 as triager.
Co-authored-by: Sam Xie <sam@samxie.me >
2025-03-10 09:33:23 +01:00
Robert Pająk
7f64adf911
[chore] Add a policy on adding tests ( #6334 )
...
Per [OpenSSF Best Practices](https://www.bestpractices.dev/en ):
> It is SUGGESTED that this policy on adding tests be documented in the
instructions for change proposals.
2025-02-19 07:40:22 -08:00
Damien Mathieu
078b2dd0d4
Add Cheng-Zhen as a triager ( #5922 )
...
This proposes adding @scorpionknifes as a triager for the Go SIG.
While Cheng-Zhen's contributions are all in the contrib repository, we
don't currently split roles between the two repos.
Cheng-Zhen's contributions in the log bridges, and his interest in being
more involved with the SIG make him a nice fit to be a triager.
2024-10-28 09:26:39 +01:00
Damien Mathieu
cd754a629d
Remove company from emeritus ( #5887 )
...
Follows https://github.com/open-telemetry/community/pull/2391
2024-10-16 17:17:23 +02:00
Robert Pająk
e500945247
Move @hanyuancheung to Emeritus status ( #5863 )
...
@hanyuancheung is no longer able to fulfil the requirements of an
[approver](https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#approver ).
This moves him out of a approver role and into an Emeritus status.
Thank you @hanyuancheung for all the contributions!
2024-10-04 07:11:40 +02:00
Tyler Yahn
4ac842cb6a
Move @MadVikingGod to Emeritus status ( #5856 )
...
Based on a change in role and priorities, @MadVikingGod is no longer
able to focus on OTel. This moves him out of a maintainer role and into
an Emeritus status.
Thank you @MadVikingGod for all the contributions!
2024-10-01 11:45:16 -07:00
Sam Xie
29c0c28a2c
Mention test-concurrent-safe CI job in CONTRIBUTING doc ( #5781 )
...
Related #5759
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2024-09-05 12:45:47 -07:00
Sam Xie
d7372079a8
Fix membership link ( #5667 )
2024-08-01 21:34:07 +02:00
Tyler Yahn
8279a1a12e
Add @XSAM and @dmathieu as repository maintainers ( #5558 )
...
After off-line discussions, the existing maintainers have all agreed
that the contributions made by both @XSAM and @dmathieu motivate adding
them as maintainers to the project. Both @XSAM and @dmathieu have
confimed they are interested in the position and willing to accept the
responsibilities.
### TODO
- [ ] Add @XSAM to maintainers group
- [ ] Add @dmathieu to maintainers group
- [ ] Copy the substance of this PR into the contrib repository
Co-authored-by: Sam Xie <sam@samxie.me >
2024-07-02 10:46:43 -07:00
ET
1438392900
Move evantorrie to emeritus status ( #5507 )
...
Removing myself as contributor since I have not approved anything in a
long time.
Co-authored-by: Sam Xie <sam@samxie.me >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2024-06-14 09:38:01 -07:00
Robert Pająk
7ba796cb39
sdk/log: Document how Processor and Exporter interfaces can be extended ( #5347 )
2024-05-11 17:21:33 +02:00
Anthony Mirabella
d0068d09e7
Move Aneurysm9 to emeritus status ( #5319 )
...
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com >
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2024-05-09 09:29:45 -07:00
Damien Mathieu
edb788bf49
Add READMEs to every package ( #5103 )
2024-03-26 20:13:54 +01:00
Aaron Clawson
cf93d0db65
Add @dashpole (David Ashpole) as a maintainer ( #4830 )
...
* Add David Ashpole as a maintainer
* Sort the maintiners by surname.
Co-authored-by: Robert Pająk <pellared@hotmail.com >
---------
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2024-01-17 16:30:45 -06:00
Liz Fong-Jones
19622d3855
chore(docs): explicitly mark lizthegrey emeritus ( #4822 )
...
* chore(docs): explicitly mark lizthegrey emeritus
Follow-on to open-telemetry/opentelemetry-go#1745 - we didn't have an emeritus section then, but we do now as of open-telemetry/opentelemetry-go#2888 .
* lint
* sort in order of date
2024-01-12 07:12:25 -08:00
Robert Pająk
8e756513a6
sdk/metric: Record measurements when context is done ( #4671 )
2023-12-15 19:14:16 +01:00
Michael Blum
ca2b22b3be
Document PR commits preference in CONTRIBUTING.md ( #4704 )
2023-11-13 08:22:34 +01:00
Tyler Yahn
d9afe946d4
Document cross-module internal package rule ( #4427 )
...
Co-authored-by: Robert Pająk <pellared@hotmail.com >
2023-08-09 15:12:17 -07:00
Robert Pająk
fd5284f75c
styleguide: tests goroutine leaks and naming ( #4348 )
...
* internal/global: Fix goroutine leaks in tests
2023-07-24 09:35:06 +02:00
Aaron Clawson
9c61b56338
Add decision about v2 API ( #3968 )
2023-06-21 18:15:03 +02:00
Robert Pająk
b2246d5865
[chore] Clarify that internal and test packages do not need docs ( #4140 )
...
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-05-26 08:23:50 -07:00
Anthony Mirabella
0cdd5cecd9
Move @Aneurysm9 to approver ( #4137 )
...
* Move @Aneurysm9 to approver
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
* Remove @Aneurysm9 from CODEOWNERS
---------
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
Co-authored-by: Tyler Yahn <codingalias@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-05-26 08:13:37 -07:00
Anthony Mirabella
bcc2af02f4
Add @pellared as maintainer ( #4138 )
...
* Add @pellared as maintainer
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
* Add @pellared as maintainer in CODEOWNERS
---------
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com >
Co-authored-by: Tyler Yahn <codingalias@gmail.com >
2023-05-26 07:49:44 -07:00
Robert Pająk
ff9fa334c9
[chore] Update documentation guidelines ( #4136 )
...
* Simplify documentation guidelines
* Add info how to localy run pkg.go.dev
2023-05-25 08:24:46 -07:00
Charlie Le
8dcabc3ef9
feat(ci): Add codespell to Makefile and GitHub Actions ( #3996 )
...
* feat(ci): Add codespell to Makefile and GitHub Actions
This is a followup from
https://github.com/open-telemetry/opentelemetry-go/pull/3980 to add the
automation for checking for code spelling errors to a different PR.
[Codespell][] makes use of the `.codespellrc` file automatically as a config
file for convenience. The configuration file specifies directories and
flags to pass to `codespell`. Codespell also makes use of the
`.codespellignore` file to ignore certain word spellings.
There is a new section in `Makefile` for installing python tooling.
It is similar to how the go tools are installed. It sets up a virtualenv
in `venv `and installs python tooling there if it hasn't been installed
yet.
The new [codespell workflow][] will run in pull requests to annotate
misspelled words. It is set up to only warn the user with annotations in
the pull request if there are typos, but we can fail the pull request as
well if we want to by deleting the [warn_only][] key.
[codespell]: https://github.com/codespell-project/codespell
[codespell workflow]: https://github.com/codespell-project/actions-codespell
[warn_only]: https://github.com/codespell-project/actions-codespell#parameter-only_warn
* Use docker to run python and codespell
Since this is a Go project, having a dependency on python seemed
disconcerting. So, docker is used to create a virtual environment
with a python image and also run the tools that were installed.
* Remove wording on requirement for python
* Apply suggestions from code review
Co-authored-by: Damien Mathieu <42@dmathieu.com >
* Pin versions into requirements.txt
* Pin version in requirements.txt
* Fix typo in license
* Revert typo fix on deleted file
* Update .github/workflows/codespell.yaml
Co-authored-by: Robert Pająk <pellared@hotmail.com >
* Update codespell.yaml
* Update codespell.yaml
---------
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
Co-authored-by: Damien Mathieu <42@dmathieu.com >
Co-authored-by: Robert Pająk <pellared@hotmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-05-18 09:06:27 -07:00
Patrice Chalin
1dff818526
[website_docs] Update path to spec, run formatter ( #4084 )
...
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
2023-05-15 06:55:29 -07:00
Robert Pająk
4d473d105a
[chore] Pin otel-specification hyperlinks ( #4033 )
...
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-05-09 08:45:39 -07:00
Joshua MacDonald
c5e2799a63
move jmacd to emeritus ( #4024 )
...
* move jmacd to emeritus
* Remove @jmacd from CODEOWNERS
---------
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
Co-authored-by: Tyler Yahn <codingalias@gmail.com >
2023-04-20 10:04:27 -07:00
Charlie Le
1b55281859
docs(typos): Run codespell to fix typos ( #3980 )
...
* docs(typos): Run codespell to fix typos
There were a lot of typos through the repository, so I ran
[codespell][], a tool for automatically fixing typos, to fix them.
```console
make codespell
```
There's already a tool called [misspell][] that's supposed to take care
of this, but misspell hasn't been updated for 6 years, and it doesn't
seem to be catching any of the typos that codespell can.
[codespell]: https://github.com/codespell-project/codespell
[misspell]: https://github.com/client9/misspell
* Revert and ignore spelling for Consequentially
* Add GH workflow for codespell
* Revert GH Workflow and Makefile for codespell
Per @pellared, since there's no instructions for setting up codespell,
it was suggested that the changes for setting up a workflow and section
in Makefile include instructions for setting up codespell as well.
* Revert spelling on consequently
---------
Co-authored-by: Chester Cheung <cheung.zhy.csu@gmail.com >
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com >
2023-04-11 17:28:13 -07:00